Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure CML is compliant with the type annotations proposal #134

Open
littlespex opened this issue Feb 18, 2025 · 0 comments
Open

Ensure CML is compliant with the type annotations proposal #134

littlespex opened this issue Feb 18, 2025 · 0 comments

Comments

@littlespex
Copy link
Collaborator

The type annotations proposal (spec) allows JS engines to strip out type declarations and run Typescript without a build step. The CML code base, including its internal build scripts, already aligns (mostly) with this proposal. This should allow us to remove dependencies like tsx once we move to a version of node that supports "type stripping". In order to fully support this proposal we should:

  • Upgrade Node dev dependency to >=23.6.
    • Enforce this requirement using devEngines property:
      "devEngines": {
        "runtime": {
          "name": "node",
          "version": ">=23.6.0",
          "onFail": "error"
        }
      },
      
  • Validate the codebase isn't using a non-supported feature via lint rules
  • Update to Typescript version 5.8
    • Update tsconfig.json to set erasableSyntaxOnly
littlespex added a commit that referenced this issue Mar 11, 2025
…bleSyntaxOnly and isolatedDeclarations constraints

see: #134
Signed-off-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant