Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate pitch (semitone and cents) and tempo (percentage) shifting? #73

Open
jadasse opened this issue Dec 12, 2024 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@jadasse
Copy link

jadasse commented Dec 12, 2024

In the Processing tab of the foo_midi menu or in the "View" tab on the FB2K toolbar, can there be two sliders to change the pitch and tempo? Sekaiju has the ability to do that, so hopefully it would be feasible on here, too! If I pitch shift with FB2K components not related to foo_midi, the MIDI might sound distorted since MIDIs are not audio files, and the rendering of the MIDI is confused for an audio file which ignores the soundfont pitch mapping; Sekaiju demonstrates the proper way MIDIs can be pitch-shifted, I am hoping that and its tempo-changing feature can similarly be ported onto foo_midi!
Another note: for MIDI players, are there plans to add one that accesses the system MIDI output devices, like OmniMIDI (which is what I use, it is a great piece of software)?

@stuerp
Copy link
Owner

stuerp commented Dec 12, 2024

Pitch and tempo at first look seem relatively easy to implement if it comes down to modifying the Note On commands and the Tempo messages.
MIDI output devices are out of scope unless they can respond with a buffer of samples. foo_midi is not a sequencer and neither is foobar2000. I need to supply a buffer of samples to fb2k to get some output. The various MIDI engines currently used have an API for that.

@jadasse
Copy link
Author

jadasse commented Dec 12, 2024

Pitch and tempo at first look seem relatively easy to implement if it comes down to modifying the Note On commands and the Tempo messages.

MIDI output devices are out of scope unless they can respond with a buffer of samples. foo_midi is not a sequencer and neither is foobar2000. I need to supply a buffer of samples to fb2k to get some output. The various MIDI engines currently used have an API for that.

Ah, that sounds great regarding the pitch and tempo; I understand what you mean regarding MIDI output devices, what I was really looking for is to select from a list of soundfonts and being able to select multiple to overlap each other in the BASSMIDI player, similar to what OmniMIDI does

@stuerp
Copy link
Owner

stuerp commented Dec 12, 2024

I've been wrestling with overlapping DLS soundfonts with varying success. The specs are confusing (or I'm not smart enough, which I don't rule out). I intend to dive deeper in it once foo_uie_webview is more mature.

@stuerp stuerp added the enhancement New feature or request label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants