Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some exceptions are not very informative for the client code #221

Closed
rkondakov opened this issue Jan 18, 2024 · 2 comments
Closed

Some exceptions are not very informative for the client code #221

rkondakov opened this issue Jan 18, 2024 · 2 comments

Comments

@rkondakov
Copy link
Contributor

Some exceptions in the code do not answer the question "what was wrong" and sometimes it requires debugging to figure out the problem with substrait plan. I propose to add some clarification to several exceptions in the code
rkondakov added a commit to rkondakov/substrait-java that referenced this issue Jan 18, 2024
@rkondakov
fix: some exceptions are not very informative for the client codel (s…
fdd3082 
…ubstrait-io#221)
rkondakov added a commit to rkondakov/substrait-java that referenced this issue Jan 18, 2024
@rkondakov
fix: some exceptions are not very informative for the client code (su…
ef7bd0c 
…bstrait-io#221)
vbarua pushed a commit that referenced this issue Jan 18, 2024
@rkondakov
feat: improved error messages for Substrait conversion failures (#221) (
8c70245 
#222)
@davisusanibar
Copy link
Contributor

Hello @rkondakov, could this issue be closed as part of #222?

@rkondakov
Copy link
Contributor Author

@davisusanibar yes, it's done. Thanks!

ajegou pushed a commit to ajegou/substrait-java that referenced this issue Mar 29, 2024
@rkondakov
feat: improved error messages for Substrait conversion failures (subs…
0ae08e4 
…trait-io#221) (substrait-io#222)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davisusanibar @rkondakov