Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fixtures for failure should be valid EXCEPT for failure being checked #114

Open
ndushay opened this issue Dec 12, 2017 · 0 comments
Open

refactor: fixtures for failure should be valid EXCEPT for failure being checked #114

ndushay opened this issue Dec 12, 2017 · 0 comments
Labels
refactor architecture, refactoring, style, etc. tech debt

Comments

@ndushay
Copy link
Contributor

ndushay commented Dec 12, 2017

For example: unless the check is about missing required manifest files, then vnnnn/manifests dir should have signatureCatalog.xml and manifestInventory.xml

This ensures our tests are looking for exactly the errors we want.

It also sets us up for "fail thoroughly" should we decide we need it
@ndushay ndushay mentioned this issue Dec 12, 2017
Closed
@ndushay ndushay changed the title (MV) fixtures for failure should be valid EXCEPT for failure being checked refactor: fixtures for failure should be valid EXCEPT for failure being checked May 11, 2022
@ndushay ndushay added refactor architecture, refactoring, style, etc. tech debt and removed patch party labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor architecture, refactoring, style, etc. tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndushay