Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve tests for Moab::StorageObjectVersion#verify_version_storage #128

Open
SaravShah opened this issue Mar 19, 2018 · 2 comments
Open

improve tests for Moab::StorageObjectVersion#verify_version_storage #128

SaravShah opened this issue Mar 19, 2018 · 2 comments
Labels
tech debt

Comments

@SaravShah
Copy link
Contributor

SaravShah commented Mar 19, 2018 •
edited
Loading

  • Current tests only test for the expected case, not for when they fail, or are false.
  • Need to add similar tests to #verify_manifest_inventory, #verify_signature_catalog, and #verify_version_inventory.
@SaravShah SaravShah changed the title (MV) Tests for StorageObjectVersion#verify_version_storage Tests for StorageObjectVersion#verify_version_storage Mar 19, 2018
@SaravShah SaravShah added this to the 2018-03-23: Sprint 15 milestone Mar 19, 2018
@ndushay ndushay changed the title Tests for StorageObjectVersion#verify_version_storage More better tests for StorageObjectVersion#verify_version_storage Mar 19, 2018
@ndushay ndushay added backlog and removed ready labels Mar 19, 2018
@ndushay ndushay removed this from the 2018-03-23: Sprint 15 milestone Mar 19, 2018
@ndushay ndushay changed the title More better tests for StorageObjectVersion#verify_version_storage (IR) More better tests for StorageObjectVersion#verify_version_storage Mar 20, 2018
@ndushay ndushay added this to the 2018-03-23: Sprint 15 milestone Mar 20, 2018
@ndushay ndushay added ready and removed backlog labels Mar 20, 2018
@ndushay ndushay changed the title (IR) More better tests for StorageObjectVersion#verify_version_storage (IR) More better tests for Moab::StorageObjectVersion#verify_version_storage Mar 23, 2018
@ndushay ndushay removed this from the 2018-03-23: Sprint 15 milestone Mar 30, 2018
@atz
Copy link
Contributor

atz commented Apr 3, 2018 •
edited
Loading

I agree, many of the tests for Moab::StorageObjectValidator also include bogus operations that do nothing and expectations that don't provide any specificity. This looks like it needs work.

@atz
Copy link
Contributor

atz commented Apr 4, 2018

Also, there was a Lint/UselessAssignment exclusion put in .rubocop.yml to ignore the meaningless assignments in spec/unit_tests/moab/storage_object_validator_spec.rb with the comment:

NOT a useless assignment - rubocop is confused

Uh.... no, those are useless. Author was confused.

@jmartin-sul jmartin-sul added backlog and removed ready labels Aug 16, 2018
@ndushay ndushay added tech debt and removed backlog labels May 11, 2022
@ndushay ndushay changed the title (IR) More better tests for Moab::StorageObjectVersion#verify_version_storage improve tests for Moab::StorageObjectVersion#verify_version_storage May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ndushay @atz @jmartin-sul @SaravShah