Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: global surfacing of known checksum algorithms #143

Open
ndushay opened this issue Apr 9, 2018 · 2 comments
Open

refactor: global surfacing of known checksum algorithms #143

ndushay opened this issue Apr 9, 2018 · 2 comments
Labels
refactor architecture, refactoring, style, etc. tech debt

Comments

@ndushay
Copy link
Contributor

ndushay commented Apr 9, 2018

#140 nicely pulls the "known algorithms" for checksum computation into a constant.

It would be great to have this constant either live in https://github.com/sul-dlss/moab-versioning/blob/master/lib/moab.rb, along with DEFAULT_CHECKSUM_TYPES -- or to find an even better place for constants like this.

Second part: ensuring the KNOWN_ALGORITHMS constant is used not only in this place, but anywhere else checksums are computed in the MV code.

Bonus points if constants like these are configurable.

@ndushay ndushay added backlog enhancement refactor architecture, refactoring, style, etc. labels Apr 9, 2018
@ndushay ndushay changed the title moab-versioning: global surfacing of known checksum algorithms MV gem: global surfacing of known checksum algorithms Apr 9, 2018
@atz
Copy link
Contributor

atz commented Apr 10, 2018

IMO, the constant shouldn't be the thing other parts of code rely on directly, but rather some method invocation that encapsulates the presence of the constant (so that configurability can play a filtering role). Same intent.

@ndushay ndushay added ready and removed backlog labels Apr 18, 2018
@ndushay
Copy link
Contributor Author

ndushay commented Apr 19, 2018

See #119

@ndushay ndushay added backlog and removed ready labels Jul 16, 2018
@ndushay ndushay changed the title MV gem: global surfacing of known checksum algorithms refactor: global surfacing of known checksum algorithms May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor architecture, refactoring, style, etc. tech debt
Projects
None yet
Development

No branches or pull requests

2 participants