Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: Schema #3

Open
DistributedDoge opened this issue Jul 29, 2023 · 3 comments
Open

Feedback: Schema #3

DistributedDoge opened this issue Jul 29, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@DistributedDoge
Copy link
Contributor

From a perspective of a person that took part in sybil-seeking hackathon, being provided a schema + db like this would have been pretty nice. On the other hand - if you are looking at a single round, a flat .csv file with votes is probably a great low-effort starting point to jump into doing analysis.

Possible additions to existing schema:

  • For each transaction that carries a vote it would be nice to know gas i.e. gas price + gas spent.
  • Likewise for each project that did apply to round on-chain I would like to see hash of transaction used to do that (+ gas fee).
  • Reporting blockNumbers for vote is nice, would be even nicer if there was also approximate_timestamp for plotting timeseries.

Key friction for me usability wise, is that I want to get clean, processed data from authoritative source without having to re-run the pipelines myself.

Interesting external information about each voter/grant address: POAPs, ENS name history, Snapshot votes

@ccerv1
Copy link
Contributor

ccerv1 commented Jul 30, 2023

Shared these with owocki on TG, but here's some additional schema feedback:

  • include payoutAddress for a projectInRound (this is the wallet address that receives grant funds) ... I noticed that grantAddress is included in the vote
  • include the githubUrl of the project/user who posted the projectInRound (this may be explicitly linked in the application or in other cases the Github username of the account leading the project)

note: these field may both be in the application metadata already, but even so would be preferable to have easily accessible

  • include 'chain' in the 'vote' table

  • agree with @DistributedDoge's comments about tx gas and timestamp

  • include passport yes/no and score for voters?? Not sure if this is possible / good idea

@poupou-web3
Copy link

Seeing Carl's comment made me think that a table with metadata would be very useful.
Going through the JSON metadata is cumbersome.
I know some fields in the metadata are mandatory and common to all applications, a table for those would be nice.

@ghostffcode
Copy link
Collaborator

Pushed an update that includes the Schema feedback provided by @DistributedDoge & @ccerv1 on #11 PR.
Expect this to be merged in the next 24 hours if no issues arise.

ghostffcode added a commit that referenced this issue Aug 15, 2023
…nux/amd64 arch (#11)

* ignore env

* docker default to linux/amd64

* update loaders & votes tx metadata loader

* update schema for #3

* add and implement viem client for tx metadata

* more console logging for progress

* configs

* update doc for metabase
ghostffcode added a commit that referenced this issue Aug 28, 2023
* ignore env

* docker default to linux/amd64

* update loaders & votes tx metadata loader

* update schema for #3

* add and implement viem client for tx metadata

* more console logging for progress

* configs

* update doc for metabase

* dev setup

* pm2 setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants