Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log messages missing from "say" with multiple robots from same template #1592

Closed
kostmo opened this issue Oct 20, 2023 · 4 comments · Fixed by #2316
Closed

log messages missing from "say" with multiple robots from same template #1592

kostmo opened this issue Oct 20, 2023 · 4 comments · Fixed by #2316
Assignees
@xsebek
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Robots An issue having to do with robots. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. Z-Documentation This issue is about README or Wikis or Haddock or... Z-User Experience This issue seeks to make the game more enjoyable to play.

Comments

@kostmo
Copy link
Member

kostmo commented Oct 20, 2023 •
edited
Loading

Two robots (created from the same template) that say at the same tick do not generate distinct log messages.

Demonstrated in #1593.

It may also be a problem when a single robot says two different things, but both invocations of say are wrapped in the same instant block.
@kostmo kostmo added the Bug The observed behaviour is incorrect or unexpected. label Oct 20, 2023
@kostmo kostmo mentioned this issue Oct 20, 2023
Closed
@byorgey
Copy link
Member

byorgey commented Oct 21, 2023

I tried to look into this, but the code for the Say command in Swarm.Game.Step is sorely lacking in comments and I gave up. I think refactoring + adding some comments is probably the first order of business!

@xsebek
Copy link
Member

xsebek commented Nov 11, 2023 •
edited
Loading

This is not a bug, but a feature! 🐛 😄 @byorgey I think addLatestClosest says it all.

IIRC the idea was that when robots shout over each other, only the closest one will be clearly heard.

I don't have a strong opinion on how it should behave now, honestly it might be best to make these restrictions configurable.
That way we would have a top-level structure documenting all the restrictions the various commands have.

EDIT: the original merge request was:

@xsebek xsebek removed the Bug The observed behaviour is incorrect or unexpected. label Nov 11, 2023
@xsebek
Copy link
Member

xsebek commented Nov 11, 2023

I must admit this information is not present in say docs, if the limitation stays then we should mention it there.

@xsebek xsebek added the Z-Documentation This issue is about README or Wikis or Haddock or... label Nov 11, 2023
@kostmo
Copy link
Member Author

kostmo commented Nov 15, 2023

My vote would be to remove the restriction. The physical justification makes sense, given a certain model of limited "radio bandwidth", but it doesn't necessarily contribute to the "fun factor"; rather it has so far frustrated the debugging process.

@byorgey byorgey added Z-User Experience This issue seeks to make the game more enjoyable to play. C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. G-Robots An issue having to do with robots. labels Sep 24, 2024
@xsebek xsebek self-assigned this Feb 8, 2025
@xsebek xsebek mentioned this issue Feb 8, 2025
Merged
@mergify mergify bot closed this as completed in #2316 Feb 10, 2025
@mergify mergify bot closed this as completed in c7fda03 Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xsebek xsebek

Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Robots An issue having to do with robots. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. Z-Documentation This issue is about README or Wikis or Haddock or... Z-User Experience This issue seeks to make the game more enjoyable to play.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove say command one message limit swarm-game/swarm
3 participants
@kostmo @byorgey @xsebek