Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should have PR checks to make sure builds don't break #73

Closed
award999 opened this issue Dec 9, 2024 · 1 comment · Fixed by #74
Closed

Should have PR checks to make sure builds don't break #73

award999 opened this issue Dec 9, 2024 · 1 comment · Fixed by #74

Comments

@award999
Copy link
Contributor

award999 commented Dec 9, 2024 •
edited
Loading

We had to quickly patch the shared workflow file with #72, after the Docker workflow broke on Windows. We should setup a simple test step for new pull requests that verifies that PRs that change the workflow file do not break builds downstream.

Should be able to use a sub workflow so changes to the workflow are tested: actions/runner#1419
@award999
Copy link
Contributor Author

award999 commented Dec 9, 2024

@shahmishal can assign this to me

This was referenced Dec 9, 2024
Merged
Open
@ahoppen ahoppen closed this as completed in b077221 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setup a simple test build to verify award999/github-workflows
1 participant
@award999