Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable Connection type keys in compile #12

Closed
norhan-synnada opened this issue Nov 15, 2024 · 0 comments · Fixed by #13
Closed

[FEATURE] Enable Connection type keys in compile #12

norhan-synnada opened this issue Nov 15, 2024 · 0 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request

Comments

@norhan-synnada
Copy link
Collaborator

norhan-synnada commented Nov 15, 2024

Feature Request

Describe the Feature

Constant, data, discard, jacobian, trainable keys and shapes arguments can be provided as strings or Connection objects to the compile function.

Motivation

User should not be forced to provide only string representations of the connections.

Proposed Solution

Add Connection type handling of the keys in compile and PhysicalModel.

Alternatives Considered

No alternatives, solution is straightforward.

Additional Context

Unnamed runtime data should be checked optionally. Add boolean safe_names argument to the compile function in order to check all runtime data (not any parameters) are named in logical model. This would make providing data and understanding data flow easier to the user if requested.

@norhan-synnada norhan-synnada added the enhancement New feature or request label Nov 15, 2024
@norhan-synnada norhan-synnada self-assigned this Nov 15, 2024
@norhan-synnada norhan-synnada changed the title [FEATURE] [FEATURE] Enable Connection type keys in compile. Nov 18, 2024
@ozankabak ozankabak changed the title [FEATURE] Enable Connection type keys in compile. [FEATURE] Enable Connection type keys in compile Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant