Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Possible naming error #208

Open
norhan-synnada opened this issue Feb 24, 2025 · 0 comments
Open

[BUG] Possible naming error #208

norhan-synnada opened this issue Feb 24, 2025 · 0 comments
Assignees
Labels

Comments

@norhan-synnada
Copy link
Collaborator

norhan-synnada commented Feb 24, 2025

Bug Report

Describe the Bug

When below model is compiled, a bug occurs in PhysicalModel (possibly in naming). Same name is assigned to different outputs.

To Reproduce

model = Model()

to_list = ToList(n=3)
concat_1 = Concat()
concat_2 = Concat()

input1 = IOKey("input1", type=Tensor)
input2 = IOKey("input2", type=Tensor)
input3 = IOKey("input3", type=Tensor)

model |= to_list(input1=input1, input2=input2, input3=input3)
model += concat_1(output="output_1")
indexed_data = to_list.output[-2:]
model |= concat_2(input=indexed_data, output="output_2")

Expected Behavior

Should be compiled with no errors.

System Info

  • OS:
  • Mithril Version:
  • Torch Version:
  • MLX Version:
  • NumPy Version:
  • JAX Version:
  • Python Version:
  • Architecture:

CC: @kberat-synnada, @norhan-synnada

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants