Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Update types of all models #221

Open
mehmetozsoy-synnada opened this issue Mar 5, 2025 · 0 comments · May be fixed by #222
Open

[OTHER] Update types of all models #221

mehmetozsoy-synnada opened this issue Mar 5, 2025 · 0 comments · May be fixed by #222

Comments

@mehmetozsoy-synnada
Copy link
Collaborator

Summary

In mithril, since now types can be polymorphic, types should be updated accordingly. Therefore types of all primitives should be implemented

Second topic of this issue is that in mithril, we currently have some values in __call__() function. These values should be carried to the init of primitive functions.

Context

  • Analyze all primitive functions of Mithril.
  • Find types of all functions.
  • Update type of primitives accordingly.
  • Update init values of all primitive functions.
  • change name cutoff to threshold
  • update tests accordingly

Additional Details

N/A

@mehmetozsoy-synnada mehmetozsoy-synnada linked a pull request Mar 5, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant