[TASK] Remove unused function (#402)

Resolves: #401

Author: sypets

Classes/Configuration/Configuration.php

@@ -2,19 +2,6 @@
 
 declare(strict_types=1);
 
-/*
- * This file is part of the TYPO3 CMS project.
- *
- * It is free software; you can redistribute it and/or modify it under
- * the terms of the GNU General Public License, either version 2
- * of the License, or any later version.
- *
- * For the full copyright and license information, please read the
- * LICENSE.txt file that was distributed with this source code.
- *
- * The TYPO3 project - inspiring people to share!
- */
-
 namespace Sypets\Brofix\Configuration;
 
 use Symfony\Component\Mime\Address;
@@ -24,7 +11,6 @@
 use Sypets\Brofix\Linktype\AbstractLinktype;
 use Sypets\Brofix\Linktype\LinktypeInterface;
 use TYPO3\CMS\Backend\Utility\BackendUtility;
-use TYPO3\CMS\Core\TypoScript\Parser\TypoScriptParser;
 use TYPO3\CMS\Core\Utility\ArrayUtility;
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
@@ -226,38 +212,6 @@ public function loadPageTsConfig(int $page): void
         $this->setTsConfig(BackendUtility::getPagesTSconfig($page)['mod.']['brofix.'] ?? []);
     }
 
-    /**
-     * Reads page TSconfig from string and overrides existing tsconfig in
-     * $this->tsconfig with the values.
-     *
-     * @param string $tsConfigString
-     * @throws \Exception
-     *
-     * @deprecated use overrideTsConfigByArray
-     */
-    public function overrideTsConfigByString(string $tsConfigString): void
-    {
-        /**
-         * @var TypoScriptParser $parseObj
-         */
-        $parseObj = GeneralUtility::makeInstance(TypoScriptParser::class);
-        $parseObj->parse($tsConfigString);
-        if (!empty($parseObj->errors)) {
-            $parseErrorMessage = 'Invalid TSconfig'
-                . '<br />';
-            foreach ($parseObj->errors as $errorInfo) {
-                $parseErrorMessage .= $errorInfo[0] . '<br />';
-            }
-            throw new \Exception($parseErrorMessage);
-        }
-        $tsConfig = $parseObj->setup;
-        $overrideTs = $tsConfig['mod.']['brofix.'];
-
-        if (is_array($overrideTs)) {
-            ArrayUtility::mergeRecursiveWithOverrule($this->tsConfig, $overrideTs);
-        }
-    }
-
     /**
      * @param array<mixed> $override
      */

Tests/Functional/AbstractFunctional.php

@@ -4,19 +4,6 @@
 
 namespace Sypets\Brofix\Tests\Functional;
 
-/*
- * This file is part of the TYPO3 CMS project.
- *
- * It is free software; you can redistribute it and/or modify it under
- * the terms of the GNU General Public License, either version 2
- * of the License, or any later version.
- *
- * For the full copyright and license information, please read the
- * LICENSE.txt file that was distributed with this source code.
- *
- * The TYPO3 project - inspiring people to share!
- */
-
 use Psr\Http\Message\ServerRequestInterface;
 use Sypets\Brofix\Command\CommandUtility;
 use Sypets\Brofix\Configuration\Configuration;
@@ -73,14 +60,26 @@ protected function initializeConfiguration(): void
             'tt_content' => ['bodytext', 'header_link', 'records']
         ];
         $linkTypes = ['db', 'file', 'external'];
+        $tsconfig = [
+            'mod' => [
+                'brofix' => [
+                    'linktypesConfig' => [
+                        'external' => [
+                            'headers' => [
+                                'User-Agent' => 'Mozilla/5.0 (compatible; Broken Link Checker; +https://example.org/imprint.html)',
+                            ]
+                        ]
+                    ]
+                ]
+            ]
+        ];
 
         $tsConfigPath = GeneralUtility::getFileAbsFileName('EXT:brofix/Configuration/TsConfig/Page/pagetsconfig.tsconfig');
         $this->configuration = GeneralUtility::makeInstance(Configuration::class, self::EXTENSION_CONFIGURATION_ARRAY);
 
         // load default values
         $this->configuration->setSearchFields($searchFields);
         $this->configuration->setLinkTypes($linkTypes);
-        $this->configuration->overrideTsConfigByString(file_get_contents($tsConfigPath));
-        $this->configuration->overrideTsConfigByString('mod.brofix.linktypesConfig.external.headers.User-Agent = Mozilla/5.0 (compatible; Broken Link Checker; +https://example.org/imprint.html)');
+        $this->configuration->overrideTsConfigByArray($tsconfig);
     }
 }

Tests/Functional/CheckLinks/ExcludeLinkTargetTest.php

@@ -4,19 +4,6 @@
 
 namespace Sypets\Brofix\Tests\Functional\CheckLinks;
 
-/*
- * This file is part of the TYPO3 CMS project.
- *
- * It is free software; you can redistribute it and/or modify it under
- * the terms of the GNU General Public License, either version 2
- * of the License, or any later version.
- *
- * For the full copyright and license information, please read the
- * LICENSE.txt file that was distributed with this source code.
- *
- * The TYPO3 project - inspiring people to share!
- */
-
 use Sypets\Brofix\CheckLinks\ExcludeLinkTarget;
 use Sypets\Brofix\Tests\Functional\AbstractFunctional;