Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGX_UI_LOADER_CONFIG_TOKEN not exported as public #111

Open
sgtonion opened this issue Oct 25, 2022 · 0 comments
Open

NGX_UI_LOADER_CONFIG_TOKEN not exported as public #111

sgtonion opened this issue Oct 25, 2022 · 0 comments

Comments

@sgtonion
Copy link

Describe the bug
NGX_UI_LOADER_CONFIG_TOKEN is not exported.

  1. This prevents user to feed configurations for the loader using Dependency Injection
  2. The NgxUiLoaderService does not currently handle Promise type values as configuration which would prevent the configuration to be set

Expected behaviour
adding in AppModule's provider: [{ provide: NGX_UI_LOADER_CONFIG_TOKEN, useFactory: callServerToGetConfiguration, deps: [HttpClient] }]

allows service to read the configuration from callServerToGetConfiguration and then apply to the ngx-loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sgtonion