Skip to content

Commit 84382e7

Browse files
committed
[nop] [#132] Cljs console appender: remove obsolete Chrome blackbox instructions
The linked page was dead, and Chrome seems to now offer script exclusion via git Chrome seems to have removed
1 parent 4456273 commit 84382e7

File tree

1 file changed

+19
-7
lines changed

1 file changed

+19
-7
lines changed

src/taoensso/timbre/appenders/core.cljc

+19-7
Original file line numberDiff line numberDiff line change
@@ -108,16 +108,28 @@
108108
(info my-js-obj) ; Send string to console
109109
(info ^:meta {:raw-console? true} my-js-obj) ; Send raw args to console
110110
111-
For accurate line numbers in Chrome, add these Blackbox[1] patterns:
112-
`/taoensso/timbre/appenders/core\\.js$`
113-
`/taoensso/timbre\\.js$`
114-
`/cljs/core\\.js$`
111+
Ignoring library / \"blackbox\" code for accurate line numbers, etc.
115112
116-
[1] Ref. https://goo.gl/ZejSvR"
113+
Most web browsers offer a feature to ignore library or \"blackbox\" code
114+
in their debugger.
117115
118-
;; TODO Any way of using something like `Function.prototype.bind`
116+
You'll probably want to ignore at least the following:
117+
`/taoensso/timbre/appenders/core\\.js$` ; Timbre console appender
118+
`/taoensso/timbre\\.js$` ; Timbre core
119+
`/cljs/core\\.js$` ; ClojureScript core
120+
121+
Depending on the browser, you can usually set up these exclusions through
122+
right-click popups and/or through a configurable list in a settings menu.
123+
124+
For example:
125+
https://developer.chrome.com/docs/devtools/settings/ignore-list/
126+
https://webkit.org/web-inspector/web-inspector-settings/
127+
https://firefox-source-docs.mozilla.org/devtools-user/debugger/how_to/ignoring_sources/index.html
128+
etc."
129+
130+
;; TODO [#132] Any way of using something like `Function.prototype.bind`
119131
;; (Ref. https://goo.gl/IZzkQB) to get accurate line numbers in all
120-
;; browsers w/o the need for Blackboxing?
132+
;; browsers w/o the need for blackboxing?
121133

122134
[& [opts]]
123135
{:enabled? true

0 commit comments

Comments
 (0)