Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default wallet if not exists #80

Open
mmrrnn opened this issue Jun 20, 2024 · 2 comments
Open

Create default wallet if not exists #80

mmrrnn opened this issue Jun 20, 2024 · 2 comments

Comments

@mmrrnn
Copy link
Collaborator

mmrrnn commented Jun 20, 2024

There's nothing we can do at the time. Response from Stan:

Marcin:

Hey @stanimal. I want to create a default account when a user launches Tari Universe for the first time. I tried to use accounts.create, but I got an error: Store error: [accounts_get_default] account not found with key default. The only working solution I found is the get_or_create_account function, which cannot be called by Tari Universe in the current implementation. Should I make it accessible for calling from the outside, or is there another easy way to accomplish this?

Stan:

Hey @marcinpapiez, this is an area I'd like to improve. One proposal written here: tari-project/tari-dan#1058
For now I suggest that you use the accounts.create_free_test_coins call which will create the account and fund it. In future this call will be removed (because it creates coins out of thin air) but it should help with testing at this stage and will create the account if it doesn't exist.

@mmrrnn mmrrnn converted this from a draft issue Jun 20, 2024
@mmrrnn mmrrnn self-assigned this Jun 20, 2024
@mmrrnn mmrrnn moved this from In Progress to Todo in Tari universe Jun 21, 2024
@sdbondi
Copy link
Member

sdbondi commented Jun 25, 2024

We can augment accounts.create to behave like accounts.create_free_test_coins which is a quicker change. Let me know if that is something you'd like sooner. I'd still like to allow deriving and depositing into an account whether it exists or not, but that will take a little longer and still needs discussion.

@mmrrnn mmrrnn removed their assignment Jul 1, 2024
@mmrrnn
Copy link
Collaborator Author

mmrrnn commented Jul 1, 2024

I believe it's not urgent for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants