Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon syn correct behavior #5771

Closed
SWvheerden opened this issue Sep 14, 2023 · 3 comments
Closed

Horizon syn correct behavior #5771

SWvheerden opened this issue Sep 14, 2023 · 3 comments
Assignees

Comments

@SWvheerden
Copy link
Collaborator

SWvheerden commented Sep 14, 2023

Currently on Horizon sync, if the node fails horizon sync, the node can be stuck in a broken state if it cannot find a peer with the exact same chain. This can leave the peer in a broken state still a user manually deletes the base node's database.

This issue is to discuss ideas

@SWvheerden
Copy link
Collaborator Author

SWvheerden commented Sep 14, 2023

The correct goal should be that when a peer exit's horizon state, the node is in the best state possible.

So when a node finds some issue with the kernel sync, it should rewind the kernels back to the starting height.
Then exit horizon sync and let listing mode + header sync decide the correct approach with a new(or same peer if the peer was not banned) peer.

@SWvheerden SWvheerden added the release-blocker Something that needs to be fixed before a release can be made label Sep 19, 2023
@SWvheerden SWvheerden removed the release-blocker Something that needs to be fixed before a release can be made label Oct 24, 2023
@SWvheerden
Copy link
Collaborator Author

Currently utxo sync is not resumable, which it should be. The utxo set is downloaded in go , but we should be able to make it so that it can resume.

@hansieodendaal
Copy link
Contributor

Fixing system-level use for #6006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants