Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify wallet scanning + recovery height #6787

Closed
hansieodendaal opened this issue Feb 5, 2025 · 1 comment
Closed

verify wallet scanning + recovery height #6787

hansieodendaal opened this issue Feb 5, 2025 · 1 comment
Assignees
@hansieodendaal

Comments

@hansieodendaal
Copy link
Contributor

verify that wallets doing recovery and or paper wallet will only scan from birthday height.
@hansieodendaal hansieodendaal self-assigned this Feb 5, 2025
@hansieodendaal hansieodendaal mentioned this issue Feb 5, 2025
Merged
4 tasks
SWvheerden pushed a commit that referenced this issue Feb 5, 2025
@hansieodendaal
feat: verify wallet recovery (#6788)
e263caa 
Description
---
- Verified wallet recovery does not always start scanning from the
genesis block instead of a bit before the closest wallet birthday block.
- **_Fixed a Windows build error introduced by #6783_**.

Motivation and Context
---
See #6787

How Has This Been Tested?
---
New unit test 
System-level testing (wallet recovery)

What process can a PR reviewer use to test or verify this change?
---
Code review

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
@hansieodendaal
Copy link
Contributor Author

Code analysis, additional unit test and system-level tests confirmed that wallet recovery start scanning height works as expected, two weeks before the wallet birthday.

See #6788 and #6792

@hansieodendaal hansieodendaal mentioned this issue Feb 6, 2025
Merged
4 tasks
SWvheerden pushed a commit that referenced this issue Feb 6, 2025
@hansieodendaal
chore: improve wallet recovery log message (#6792)
9e3ef5b 
Description
---
Improved the wallet recovery log message:

```rust
2025-02-06 09:02:50.398360400 [wallet::utxo_scanning] INFO  Fresh wallet recovery/scanning: Wallet birthday 
'1124' at epoch time '1738108800' with block height '81', scanning from epoch time '1736899200' at block height 
'0' with header hash '68bb2afefbaf579aefcce9a7160c3e503177857df36c7885b1d3af054e253330'
```

Motivation and Context
---
When a user sees an info message about recovery, this message will make
it clear what the birthday is and what the starting scan height is.

See #6787.

How Has This Been Tested?
---
System-level testing

What process can a PR reviewer use to test or verify this change?
---
Code review

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansieodendaal hansieodendaal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hansieodendaal