chore: update tari-crypto and curve library dependencies
#6228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (Integration tests) 2 files 11 suites 31m 42s ⏱️ For more details on these failures, see this check. Results for commit 8219fb0. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 120 suites 42m 35s ⏱️ Results for commit 8219fb0. ♻️ This comment has been updated with latest results. |
AaronFeickert
force-pushed
the
crypto-update
branch
3 times, most recently
from
21af0cb to
67a85f4
Compare
AaronFeickert
changed the title
tari-crypto and curve library dependencies
AaronFeickert
force-pushed
the
crypto-update
branch
from
90263ee to
25ff611
Compare
SWvheerden
pushed a commit
that referenced
this pull request
Apr 2, 2024
Description --- Bumps the nightly toolchain to `nightly-2024-02-04` in preparation for a curve library update. Motivation and Context --- An upcoming curve library update in #6228 will require moving the nightly toolchain. In preparation, this PR moves it as far as it can go without breaking. This lets us take care of lints now. How Has This Been Tested? --- Existing CI (but with the updated toolchain) passes. What process can a PR reviewer use to test or verify this change? --- Check that CI passes, that the nightly toolchain update is consistently applied, and that all code changes reflect only lint fixes.
AaronFeickert
force-pushed
the
crypto-update
branch
5 times, most recently
from
5434608 to
b07f7a0
Compare
AaronFeickert
force-pushed
the
crypto-update
branch
3 times, most recently
from
8a82c3a to
85e784f
Compare
AaronFeickert
force-pushed
the
crypto-update
branch
2 times, most recently
from
5249bad to
6e4484d
Compare
AaronFeickert
force-pushed
the
crypto-update
branch
2 times, most recently
from
ce2cf59 to
4475341
Compare
AaronFeickert
force-pushed
the
crypto-update
branch
4 times, most recently
from
9bf29a0 to
16ef9ae
Compare
SWvheerden
reviewed
May 10, 2024
That was a holdover from earlier testing. I'll undo it. |
AaronFeickert
force-pushed
the
crypto-update
branch
from
793ef4d to
3778841
Compare
ghpbot-tari-project
removed
the
P-reviews_required
leet4tari
previously approved these changes
May 13, 2024
AaronFeickert
force-pushed
the
crypto-update
branch
2 times, most recently
from
ac4076d to
6f9b5f8
Compare
AaronFeickert
dismissed stale reviews from leet4tari and hansieodendaal
via
bd66a15
AaronFeickert
force-pushed
the
crypto-update
branch
from
6f9b5f8 to
bd66a15
Compare
ghpbot-tari-project
added
the
P-reviews_required
SWvheerden
approved these changes
May 17, 2024
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
tari-cryptoand associated dependencies. Bumps the nightly toolchain. Fixes lints. Removes unused code.Closes #6138.
Motivation and Context
Updates to
tari-cryptoand related dependencies allow for a return to the upstream curve library. This also requires bumping the nightly toolchain, which brings fun new lints that need to be fixed. This PR addresses all of these, and removes unused code.How Has This Been Tested?
Existing tests pass.
What process can a PR reviewer use to test or verify this change?
Watch that CI! Ensure that the removed code is unused.