feat!: change tar address to use base58 and not hex #6372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 120 suites 45m 16s ⏱️ Results for commit 3538e6f. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files 11 suites 33m 15s ⏱️ For more details on these failures, see this check. Results for commit 3538e6f. ♻️ This comment has been updated with latest results. |
SWvheerden
force-pushed
the
sw_change_base58
branch
from
7a90565 to
53b733a
Compare
SWvheerden
force-pushed
the
sw_change_base58
branch
from
378c739 to
a38d162
Compare
|
Some clippy and compile issues? |
hansieodendaal
previously approved these changes
Jun 20, 2024
Comment on lines
+183
to
+188
| let bytes = self.to_bytes(); | ||
| let mut network = bs58::encode(&bytes[0..1]).into_string(); | ||
| let features = bs58::encode(&bytes[1..2].to_vec()).into_string(); | ||
| let rest = bs58::encode(&bytes[2..]).into_string(); | ||
| network.push_str(&features); | ||
| network.push_str(&rest); | ||
| network |
There was a problem hiding this comment.
NIT: I still think this reads better
Suggested change
| let bytes = self.to_bytes(); | |
| let mut network = bs58::encode(&bytes[0..1]).into_string(); | |
| let features = bs58::encode(&bytes[1..2].to_vec()).into_string(); | |
| let rest = bs58::encode(&bytes[2..]).into_string(); | |
| network.push_str(&features); | |
| network.push_str(&rest); | |
| network | |
| let bytes = self.to_bytes(); | |
| let network = bs58::encode(&bytes[0..1]).into_string(); | |
| let features = bs58::encode(&bytes[1..2].to_vec()).into_string(); | |
| let rest = bs58::encode(&bytes[2..]).into_string(); | |
| let mut address = "".into_string(); | |
| address.push_str(&network); | |
| address.push_str(&features); | |
| address.push_str(&rest); | |
| address |
ghpbot-tari-project
removed
P-reviews_required
SWvheerden
changed the title
ghpbot-tari-project
added
the
P-reviews_required
|
Some cucumber tests are still failing |
SWvheerden
force-pushed
the
sw_change_base58
branch
from
2d7bd92 to
539c5c3
Compare
ghpbot-tari-project
removed
the
P-reviews_required
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove hex display from tari address
Use Base 58 encoding instead.
Keeps the network and features human readable
Motivation and Context
reduces the display size from 134 chars, down to 92
How Has This Been Tested?
unit tests and manual