Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(feature): add auditable assets, build macOS-14 builds #6408

Merged

Conversation

leet4tari
Copy link
Contributor

@leet4tari leet4tari commented Jul 16, 2024

Description
All native binary builds have auditable info embedded
Fix macOS-14 build missing github runner missing build dependency
Add CI build debug option (disabled by default)

Motivation and Context
Better auditing and some debugging tools

How Has This Been Tested?
Builds in local fork, needs local run testing for all platforms and builds.

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@leet4tari leet4tari requested a review from a team as a code owner July 16, 2024 14:46
@leet4tari leet4tari changed the title [WIP] Add debug/release builds with auditable assets [WIP] ci(feature): Add debug/release builds with auditable assets Jul 16, 2024
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 16, 2024
@leet4tari leet4tari marked this pull request as draft July 16, 2024 14:50
Copy link

github-actions bot commented Jul 16, 2024

Test Results (CI)

    3 files     98 suites   35m 24s ⏱️
1 294 tests 1 293 ✅ 0 💤 1 ❌
2 901 runs  2 900 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 3f01059.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 16, 2024

Test Results (Integration tests)

 2 files  11 suites   24m 47s ⏱️
35 tests 33 ✅ 0 💤 2 ❌
37 runs  35 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 162a8ed.

♻️ This comment has been updated with latest results.

@leet4tari leet4tari force-pushed the build-bins-leet-auditable branch from 84b568e to 162a8ed Compare July 24, 2024 11:11
@leet4tari leet4tari changed the title [WIP] ci(feature): Add debug/release builds with auditable assets ci(feature): Add auditable assets, build macOS-14 builds Jul 24, 2024
@leet4tari leet4tari changed the title ci(feature): Add auditable assets, build macOS-14 builds ci(feature): add auditable assets, build macOS-14 builds Jul 24, 2024
…or and deps, fix macOS-14 build deps, add debug CI build option
@leet4tari leet4tari force-pushed the build-bins-leet-auditable branch from 456101a to 3f01059 Compare July 24, 2024 12:43
@leet4tari leet4tari marked this pull request as ready for review July 24, 2024 12:49
@SWvheerden SWvheerden merged commit e12feca into tari-project:development Jul 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants