Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove temp code #6430

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Removes temp code as rust has now upgraded to 1.80 stable

@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Test Results (CI)

    2 files     73 suites   27m 18s ⏱️
1 294 tests 1 293 ✅ 0 💤 1 ❌
2 426 runs  2 425 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 5368977.

♻️ This comment has been updated with latest results.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jul 26, 2024
Copy link

github-actions bot commented Jul 26, 2024

Test Results (Integration tests)

 2 files  11 suites   41m 32s ⏱️
35 tests 34 ✅ 0 💤 1 ❌
37 runs  34 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 5368977.

♻️ This comment has been updated with latest results.

@AaronFeickert AaronFeickert linked an issue Jul 30, 2024 that may be closed by this pull request
Copy link
Collaborator

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending CI.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Jul 30, 2024
@SWvheerden SWvheerden force-pushed the sw_remove_temp_code branch from a0f8736 to 5368977 Compare July 31, 2024 13:52
Copy link
Contributor

@brianp brianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@SWvheerden SWvheerden merged commit 63fa7e3 into tari-project:development Aug 1, 2024
13 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_remove_temp_code branch August 5, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use slice::split_at_checked when stable
4 participants