feat(network): implement basic peer banning #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 126 suites 10m 3s ⏱️ Results for commit 5043af7. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files 1 errors 9 suites 1h 41m 50s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 5043af7. ♻️ This comment has been updated with latest results. |
SWvheerden
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(network): implement basic peer banning
feat(network): basic impl of fail2ban logs
fix: improve whois command
Motivation and Context
Peers were marked as banned but the ban was not enforced.
This PR also includes logs that can be used to implement fail2ban.
Note bans are not enforced in the application on restart (no persistence). However if fail2ban is implemented the ban will continue to be enforced there.
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Breaking Changes