Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: explictly close rpc connections when changing base node #6662

Merged
merged 32 commits into from
Nov 8, 2024

Merge pull request #6 from hansieodendaal/ho_wallet_connectivity_2

e96337b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix!: explictly close rpc connections when changing base node #6662

Merge pull request #6 from hansieodendaal/ho_wallet_connectivity_2
e96337b
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Integration tests) failed Nov 7, 2024 in 0s

1 parse errors, 4 fail, 14 pass in 1h 34m 39s

 2 files  ±0   1 errors  9 suites  ±0   1h 34m 39s ⏱️ ±0s
18 tests ±0  14 ✅ ±0  0 💤 ±0   4 ❌ ±0 
26 runs  ±0  14 ✅ ±0  0 💤 ±0  12 ❌ ±0 

Results for commit e96337b. ± Comparison against earlier commit c4f3f00.

Annotations

Check failure on line 0 in artifacts/junit-ffi-cucumber/cucumber-output-junit.xml

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

Error processing result file 

File is empty.
Raw output 
artifacts/junit-ffi-cucumber/cucumber-output-junit.xml

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

All 3 runs failed: Scenario: When a new node joins the network, it receives all peers: tests/features/Sync.feature:77:3 

artifacts/junit-cucumber/cucumber-output-junit.xml [took 2m 3s]
Raw output 
Step panicked. Captured output: Node NODE2 only received 1 of 11 expected peers
  Scenario: When a new node joins the network, it receives all peers
   ✔  Given I have 10 seed nodes
   ✔  When I have a base node NODE1 connected to all seed nodes
   ✔  When I wait for NODE1 to have 10 connections
   ✔  When I have a base node NODE2 connected to node NODE1
   ✔  Then NODE1 has at least 11 peers
   ✘  Then NODE2 has at least 11 peers
      Step failed:
      Defined: tests/features/Sync.feature:83:5
      Matched: integration_tests/tests/steps/node_steps.rs:933:1
      Step panicked. Captured output: Node NODE2 only received 1 of 11 expected peers
      Client {
          base_nodes: {},
          blocks: {},
          miners: {},
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {},
          seed_nodes: [
              "seed_node_0",
              "seed_node_1",
              "seed_node_2",
              "seed_node_3",
              "seed_node_4",
              "seed_node_5",
              "seed_node_6",
              "seed_node_7",
              "seed_node_8",
              "seed_node_9",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

All 3 runs failed: Scenario: As a wallet I want to submit a transaction: tests/features/WalletQuery.feature:18:3 

artifacts/junit-cucumber/cucumber-output-junit.xml [took 8m 44s]
Raw output 
Step panicked. Captured output: Transaction from WALLET_A to WALLET_B with amount 5 at fee 10 failed to be broadcasted
  Scenario: As a wallet I want to submit a transaction
   ✔  Given I have a seed node NODE
   ✔  When I have 1 base nodes connected to all seed nodes
   ✔  When I have wallet WALLET_A with 10T connected to base node NODE
   ✔  When I have wallet WALLET_B connected to base node NODE
   ✔  When I wait 5 seconds
   ✘  When I transfer 5T from WALLET_A to WALLET_B
      Step failed:
      Defined: tests/features/WalletQuery.feature:24:5
      Matched: integration_tests/tests/steps/wallet_steps.rs:1428:1
      Step panicked. Captured output: Transaction from WALLET_A to WALLET_B with amount 5 at fee 10 failed to be broadcasted
      Client {
          base_nodes: {},
          blocks: {},
          miners: {
              "temp_miner": MinerProcess {
                  name: "temp_miner",
                  base_node_name: "NODE",
                  wallet_name: "WALLET_A",
                  mine_until_height: 100000,
                  stealth: false,
              },
          },
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {
              "WALLET_A": "NODE",
              "WALLET_B": "NODE",
          },
          seed_nodes: [
              "NODE",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

All 3 runs failed: Scenario: Wallet imports pre_mine UTXO: tests/features/WalletTransactions.feature:170:3 

artifacts/junit-cucumber/cucumber-output-junit.xml [took 8m 51s]
Raw output 
Step panicked. Captured output: Transaction from WALLET_A to WALLET_B with amount 1000000 at fee 100 failed to be broadcasted
  Scenario: Wallet imports pre_mine UTXO
   ✔  Given I have a seed node NODE
   ✔  When I have 1 base nodes connected to all seed nodes
   ✔  When I have wallet WALLET_A connected to all seed nodes
   ✔  When I have wallet WALLET_B connected to all seed nodes
   ✔  When I have wallet WALLET_C connected to all seed nodes
   ✔  When I have mining node MINER connected to base node NODE and wallet WALLET_A
   ✔  When mining node MINER mines 5 blocks
   ✔  Then all nodes are at height 5
   ✔  Then I wait for wallet WALLET_A to have at least 10000000000 uT
   ✘  When I send 1000000 uT from wallet WALLET_A to wallet WALLET_B at fee 100
      Step failed:
      Defined: tests/features/WalletTransactions.feature:180:5
      Matched: integration_tests/tests/steps/wallet_steps.rs:849:1
      Step panicked. Captured output: Transaction from WALLET_A to WALLET_B with amount 1000000 at fee 100 failed to be broadcasted
      Client {
          base_nodes: {},
          blocks: {},
          miners: {
              "MINER": MinerProcess {
                  name: "MINER",
                  base_node_name: "NODE",
                  wallet_name: "WALLET_A",
                  mine_until_height: 100000,
                  stealth: false,
              },
          },
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {
              "WALLET_A": "NODE",
              "WALLET_B": "NODE",
              "WALLET_C": "NODE",
          },
          seed_nodes: [
              "NODE",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

All 3 runs failed: Scenario: As a wallet send to a wallet connected to a different base node: tests/features/WalletTransfer.feature:9:3 

artifacts/junit-cucumber/cucumber-output-junit.xml [took 8m 45s]
Raw output 
Step panicked. Captured output: Transaction from WALLET_A to WALLET_B with amount 5 at fee 10 failed to be broadcasted
  Scenario: As a wallet send to a wallet connected to a different base node
   ✔  Given I have a seed node SEED_A
   ✔  When I have a seed node SEED_B
   ✔  When I have a base node NODE_A connected to all seed nodes
   ✔  When I have a base node NODE_B connected to all seed nodes
   ✔  When I have wallet WALLET_A with 10T connected to base node NODE_A
   ✔  When I have wallet WALLET_B connected to base node NODE_B
   ✔  When I wait 5 seconds
   ✘  When I transfer 5T from WALLET_A to WALLET_B
      Step failed:
      Defined: tests/features/WalletTransfer.feature:17:5
      Matched: integration_tests/tests/steps/wallet_steps.rs:1428:1
      Step panicked. Captured output: Transaction from WALLET_A to WALLET_B with amount 5 at fee 10 failed to be broadcasted
      Client {
          base_nodes: {},
          blocks: {},
          miners: {
              "temp_miner": MinerProcess {
                  name: "temp_miner",
                  base_node_name: "NODE_A",
                  wallet_name: "WALLET_A",
                  mine_until_height: 100000,
                  stealth: false,
              },
          },
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {
              "WALLET_A": "NODE_A",
              "WALLET_B": "NODE_B",
          },
          seed_nodes: [
              "SEED_A",
              "SEED_B",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

18 tests found 

There are 18 tests, see "Raw output" for the full list of tests.
Raw output 
Scenario: As a wallet I want to submit a transaction: tests/features/WalletQuery.feature:18:3
Scenario: As a wallet send to a wallet connected to a different base node: tests/features/WalletTransfer.feature:9:3
Scenario: Clear out mempool: tests/features/Mempool.feature:46:3
Scenario: Create burn transaction: tests/features/WalletTransactions.feature:412:3
Scenario: Node rolls back reorg on invalid block: tests/features/Reorgs.feature:63:3
Scenario: Simple block sync: tests/features/Sync.feature:26:3
Scenario: Simple propagation: tests/features/Propagation.feature:26:3
Scenario: Simple reorg to stronger chain: tests/features/Reorgs.feature:8:3
Scenario: Simple reorg with burned output: tests/features/Reorgs.feature:33:3
Scenario: Sync burned output: tests/features/Sync.feature:34:3
Scenario: Transactions are propagated through a network: tests/features/Mempool.feature:8:3
Scenario: Verify UTXO and kernel MMR size in header: tests/features/BlockTemplate.feature:8:1
Scenario: Verify gprc can create block with more than 1 coinbase: tests/features/BlockTemplate.feature:14:5
Scenario: Wallet imports pre_mine UTXO: tests/features/WalletTransactions.feature:170:3
Scenario: Wallet recovery with connected base node staying online: tests/features/WalletRecovery.feature:8:5
Scenario: Wallet sending and receiving one-sided transactions: tests/features/WalletTransactions.feature:8:3
Scenario: When a new node joins the network, it receives all peers: tests/features/Sync.feature:77:3
Scenario: Zero-conf transactions: tests/features/Mempool.feature:124:3
View more details on GitHub Actions