fix: the smt cache height #6757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI) 3 files 129 suites 37m 29s ⏱️ Results for commit e46aa85. ♻️ This comment has been updated with latest results. |
Test Results (Integration tests) 2 files + 2 11 suites +11 47m 24s ⏱️ + 47m 24s For more details on these failures, see this check. Results for commit e46aa85. ± Comparison against base commit f0cf697. ♻️ This comment has been updated with latest results. |
stringhandler
previously approved these changes
Jan 23, 2025
| ) -> Result<Self, ChainStorageError> { | ||
| let env = store.env(); | ||
| let smt_cache_period = if prune_interval == 0 { | ||
| let smt_cache_period = if pruning_horizon == 0 || prune_interval == 0 { |
There was a problem hiding this comment.
maybe add a comment here what the thinking is, because it's not clear why the interval / 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the smt by default is cached every 25 blocks, which is too much. reduce this down to 500 by default for archival nodes.