Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump knative.dev/pkg to release-1.17 #8538

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vdemeester
Copy link
Member

Changes

But we enforce KUBERNETES_MIN_VERSION stays the same as today, aka k8s
1.28.x.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Bump knative.dev/pkg to release-1.17 while keeping `KUBERNETES_MIN_VERSION` to 1.28.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member Author

cc @afrittoli

@vdemeester
Copy link
Member Author

This relates to #8529 but doesn't necessarily close it as we need to define some rules on this.

@waveywaves
Copy link
Member

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2025
@vdemeester
Copy link
Member Author

@waveywaves @afrittoli 2092e23 changes some hack codegen flags as they changed...

@afrittoli
Copy link
Member

@vdemeester k8s 1.28 is EOL though. I'm fine to do the update in a separate PR, but we should get in a cadence where we don't support k8s EOL releases in our latest release.

@vdemeester
Copy link
Member Author

@vdemeester k8s 1.28 is EOL though. I'm fine to do the update in a separate PR, but we should get in a cadence where we don't support k8s EOL releases in our latest release.

If we didn't update knative.dev/pkg library today, we wouldn't bump the minimum kubernetes api version, and thus we would "support" 1.28 (as main branch does today). Also the KUBERNETES_MIN_VERSION doesn't necessarily means that we support it, it means that it doesn't panic on 1.28 (and most likely runs). The tests on k8s-oldest are running on 1.28 today as well.

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/status/status.go 87.2% 82.1% -5.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/status/status.go 87.2% 82.1% -5.1

@waveywaves
Copy link
Member

/assign

But we enforce KUBERNETES_MIN_VERSION stays the same as today, aka k8s
1.28.x.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
With the update of k8s dependencies, most of the codegen commands
changed (different flags, …), so this is adapting them.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/status/status.go 87.2% 82.1% -5.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/status/status.go 87.2% 82.1% -5.1

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/status/status.go 87.2% 82.1% -5.1

@vdemeester
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants