Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm aborted update retries schedule responsible for robustness of update to CAN #7164

Open
dandavison opened this issue Jan 27, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@dandavison
Copy link
Contributor

dandavison commented Jan 27, 2025

temporalio/features:features/continue_as_new/updates_do_not_block_continue_as_new is a feature test that confirms that, when an update is admitted while a WFT is in-flight, and that WFT CANs, that the update lands on the next run.

This behavior relies on the update being aborted, and retried (our intention is that these retries are done by gRPC interceptors and/or history client in the Frontend service). However, currently, the error responses are being returned to the SDK caller; the desired behavior occurs because the SDK client retries the ResourceExhaustedFailure. So:

  • We need to make the server retry this internally (at least, that was out original intention)
  • I think that we want to confirm that retries will be spread out in time such that races with the CAN handling are very unlikely.
@dandavison dandavison added the enhancement New feature or request label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant