Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution tracker unnecessary warnings #1361

Open
pilkicTT opened this issue Mar 4, 2025 · 5 comments
Open

Execution tracker unnecessary warnings #1361

pilkicTT opened this issue Mar 4, 2025 · 5 comments
Assignees
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@pilkicTT
Copy link
Contributor

pilkicTT commented Mar 4, 2025

Execution tracker prints out unneeded warnings which can only confuse the user. From my understanding this tool should be used only as part of the test infrastructure, so in that sense it doesn't make sense to be active when we are not running tests.

If we want to expose it to the user then clear APIs need to be provided.

Example:

2025-03-04 10:40:34.563 | INFO     | forge.compile:compile_main:227 - Compiling module Add
2025-03-04 10:40:34.564 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage init_compile
2025-03-04 10:40:34.564 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage generate_initial_graph
2025-03-04 10:40:34.564 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.071 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.072 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.093 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.116 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.145 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.146 | DEBUG    | forge.tvm_to_python:_determine_node_dtype:2149 - Node 'x1' does not have a framework dtype specified. Using TVM generated dtype.
2025-03-04 10:40:36.146 | DEBUG    | forge.tvm_to_python:_determine_node_dtype:2149 - Node 'x2' does not have a framework dtype specified. Using TVM generated dtype.
2025-03-04 10:40:36.148 | DEBUG    | forge.verify.compare:compare_tensor_to_golden:289 - Tensors match on Framework vs. Forge codegen output 0
2025-03-04 10:40:36.148 | INFO     | forge.tvm_to_python:verify_framework_vs_forge_codegen:1955 - Verified python codegen agains framework
2025-03-04 10:40:36.149 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.156 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.156 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage post_initial_graph_pass
2025-03-04 10:40:36.161 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.162 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage optimized_graph
2025-03-04 10:40:36.179 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.185 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.185 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage post_autograd_pass
2025-03-04 10:40:36.191 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.191 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage consteval_graph
2025-03-04 10:40:36.196 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.196 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage pre_lowering_pass
2025-03-04 10:40:36.200 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.200 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage split_graph
2025-03-04 10:40:36.206 | WARNING  | forge.execution_tracker:record_execution_phase_and_stage:177 - Unable to find current test
2025-03-04 10:40:36.206 | INFO     | forge.compile:forge_compile_from_context:286 - Running compile stage run_mlir_compiler
2025-03-04 10:40:36.208 | INFO     | Always          - Emitting mlir for function forward

@pilkicTT pilkicTT added bug Something isn't working invalid This doesn't seem right labels Mar 4, 2025
@pilkicTT
Copy link
Contributor Author

pilkicTT commented Mar 4, 2025

@nvukobratTT FYI

@nvukobratTT
Copy link
Contributor

Thanks @pilkicTT ! @chandrasekaranpradeep let's pick this one, should be trivial change :))

@chandrasekaranpradeep
Copy link
Contributor

@pilkicTT Can you please share the command which produces the above warning message(i.e Unable to find current test)?

@pilkicTT
Copy link
Contributor Author

pilkicTT commented Mar 4, 2025

Execute the following python code (outside of test):

import forge
import torch
import torch.nn as nn

class Add(nn.Module):
    def __init__(self):
        super().__init__()

    def forward(self, x1, x2):
        return torch.add(x1, x2)

model = Add()
shape = (1, 1024, 32)
inputs = [torch.rand(shape), torch.rand(shape)]

compiled_model = forge.compile(model, sample_inputs=[torch.rand(shape), torch.rand(shape)])

@chandrasekaranpradeep
Copy link
Contributor

chandrasekaranpradeep commented Mar 4, 2025

@pilkicTT Thanks for sharing it. Will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants