Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate GS CI failures #135

Closed
joelsmithTT opened this issue Oct 9, 2024 · 1 comment · Fixed by #138
Closed

Investigate GS CI failures #135

joelsmithTT opened this issue Oct 9, 2024 · 1 comment · Fixed by #138
Assignees
@broskoTT

Comments

@joelsmithTT
Copy link
Contributor

#97 enabled unit tests for Grayskull.

It looks like the GS unit tests may make assumptions about hardware harvesting state.

Some example failures:
https://github.com/tenstorrent/tt-umd/actions/runs/11257843046/job/31303194072
https://github.com/tenstorrent/tt-umd/actions/runs/11257843046/job/31303194531
https://github.com/tenstorrent/tt-umd/actions/runs/11257843046/job/31303190268
https://github.com/tenstorrent/tt-umd/actions/runs/11257843046/job/31303191367

Possible fix: query the device for actual harvesting state and use that for the "simulated" config.
@joelsmithTT
Copy link
Contributor Author

@broskoTT I see that you opened PR for this at #138 so assigning to you.

@broskoTT broskoTT linked a pull request Oct 10, 2024 that will close this issue
Fix Grayskull tests #138
Merged
@broskoTT broskoTT added the bug label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@broskoTT broskoTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Grayskull tests tenstorrent/tt-umd
2 participants
@joelsmithTT @broskoTT