Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the logic to add -1 depth account-group as immediate parent #162

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

namratabhadauriya
Copy link
Contributor

Description

Correct the logic to add -1 depth account-group as immediate parent instead of making same depth account group as parent

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@namratabhadauriya
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

ocofaigh commented Apr 2, 2024

@toddgiguere want to take a look?

@namratabhadauriya
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

@namratabhadauriya I see the tests failing with: Error: DeleteAccountWithContext failed Gateway Timeout - is there some backend issue?

@namratabhadauriya
Copy link
Contributor Author

/run pipeline

@namratabhadauriya
Copy link
Contributor Author

@ocofaigh @toddgiguere I am not sure, on vacation currently, pipeline is passing now can you please review it.

@toddgiguere
Copy link

@ocofaigh the source looks good, I think I would classify this as a "fix" and not a "feat"? I think it will be a bugfix officially, so a patch version makes more sense?

@ocofaigh ocofaigh merged commit 774d2e4 into main Apr 17, 2024
2 checks passed
@ocofaigh ocofaigh deleted the enterprise_module branch April 17, 2024 15:27
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants