Skip to content

Commit d8f161f

Browse files
authored
Merge pull request #8 from scverse-bot/template-update-theislab-ehrdata-v0.3.1
Update template to v0.3.1
2 parents 4689415 + e0602fa commit d8f161f

File tree

5 files changed

+26
-23
lines changed

5 files changed

+26
-23
lines changed

.cruft.json

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"template": "https://github.com/scverse/cookiecutter-scverse",
3-
"commit": "8e96abb5c3e2d5078c44713958da672711cf2a48",
4-
"checkout": "v0.3.0",
3+
"commit": "586b1652162ff7994b0070a034023d64289ae416",
4+
"checkout": "v0.3.1",
55
"context": {
66
"cookiecutter": {
77
"project_name": "ehrdata",
@@ -13,7 +13,8 @@
1313
"project_repo": "https://github.com/theislab/ehrdata",
1414
"license": "Apache License Version 2.0",
1515
"_copy_without_render": [
16-
".github/workflows/**.yaml",
16+
".github/workflows/build.yaml",
17+
".github/workflows/test.yaml",
1718
"docs/_templates/autosummary/**.rst"
1819
],
1920
"_render_devdocs": false,

.github/workflows/release.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
runs-on: ubuntu-latest
1212
environment:
1313
name: pypi
14-
url: https://pypi.org/p/{{ cookiecutter.package_name }}
14+
url: https://pypi.org/p/ehrdata
1515
permissions:
1616
id-token: write # IMPORTANT: this permission is mandatory for trusted publishing
1717
steps:

.pre-commit-config.yaml

+6-8
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,26 @@ default_stages:
66
- push
77
minimum_pre_commit_version: 2.16.0
88
repos:
9-
- repo: https://github.com/psf/black
10-
rev: "24.2.0"
11-
hooks:
12-
- id: black
13-
- repo: https://github.com/asottile/blacken-docs
14-
rev: 1.16.0
15-
hooks:
16-
- id: blacken-docs
179
- repo: https://github.com/pre-commit/mirrors-prettier
1810
rev: v4.0.0-alpha.8
1911
hooks:
2012
- id: prettier
13+
<<<<<<< ours
2114
# Newer versions of node don't work on systems that have an older version of GLIBC
2215
# (in particular Ubuntu 18.04 and Centos 7)
2316
# EOL of Centos 7 is in 2024-06, we can probably get rid of this then.
2417
# See https://github.com/scverse/cookiecutter-scverse/issues/143 and
2518
# https://github.com/jupyterlab/jupyterlab/issues/12675
19+
=======
20+
>>>>>>> theirs
2621
- repo: https://github.com/astral-sh/ruff-pre-commit
2722
rev: v0.2.1
2823
hooks:
2924
- id: ruff
25+
types_or: [python, pyi, jupyter]
3026
args: [--fix, --exit-non-zero-on-fix]
27+
- id: ruff-format
28+
types_or: [python, pyi, jupyter]
3129
- repo: https://github.com/pre-commit/pre-commit-hooks
3230
rev: v4.5.0
3331
hooks:

docs/contributing.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ Before making a release, you need to update the version number in the `pyproject
9393
> Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.
9494
9595
Once you are done, commit and push your changes and navigate to the "Releases" page of this project on GitHub.
96-
Specify `vX.X.X` as a tag name and create a release. For more information, see [managing Github releases][]. This will automatically create a git tag and trigger a Github workflow that creates a release on PyPI.
96+
Specify `vX.X.X` as a tag name and create a release. For more information, see [managing GitHub releases][]. This will automatically create a git tag and trigger a Github workflow that creates a release on PyPI.
9797

9898
## Writing documentation
9999

@@ -157,3 +157,4 @@ open _build/html/index.html
157157
[numpydoc]: https://numpydoc.readthedocs.io/en/latest/format.html
158158
[sphinx autodoc typehints]: https://github.com/tox-dev/sphinx-autodoc-typehints
159159
[pypi]: https://pypi.org/
160+
[managing GitHub releases]: https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository

pyproject.toml

+13-10
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ dependencies = [
3131
"seaborn",
3232

3333
# for debug logging (referenced from the issue template)
34-
"session-info"
34+
"session-info",
3535
]
3636

3737
[project.optional-dependencies]
3838
dev = [
3939
"pre-commit",
40-
"twine>=4.0.2"
40+
"twine>=4.0.2",
4141
]
4242
doc = [
4343
"docutils>=0.8,!=0.18.*,!=0.19.*",
@@ -71,12 +71,15 @@ addopts = [
7171
"--import-mode=importlib", # allow using test files with same name
7272
]
7373

74-
[tool.black]
75-
line-length = 120
76-
7774
[tool.ruff]
78-
src = ["src"]
7975
line-length = 120
76+
src = ["src"]
77+
extend-include = ["*.ipynb"]
78+
79+
[tool.ruff.format]
80+
docstring-code-format = true
81+
82+
[tool.ruff.lint]
8083
select = [
8184
"F", # Errors detected by Pyflakes
8285
"E", # Error detected by Pycodestyle
@@ -91,7 +94,7 @@ select = [
9194
"RUF100", # Report unused noqa directives
9295
]
9396
ignore = [
94-
# line too long -> we accept long comment lines; black gets rid of long code lines
97+
# line too long -> we accept long comment lines; formatter gets rid of long code lines
9598
"E501",
9699
# Do not assign a lambda expression, use a def -> lambda expression assignments are convenient
97100
"E731",
@@ -118,10 +121,10 @@ ignore = [
118121
"D213",
119122
]
120123

121-
[tool.ruff.pydocstyle]
124+
[tool.ruff.lint.pydocstyle]
122125
convention = "numpy"
123126

124-
[tool.ruff.per-file-ignores]
127+
[tool.ruff.lint.per-file-ignores]
125128
"docs/*" = ["I"]
126129
"tests/*" = ["D"]
127130
"*/__init__.py" = ["F401"]
@@ -135,5 +138,5 @@ skip = [
135138
"docs/changelog.md",
136139
"docs/references.bib",
137140
"docs/references.md",
138-
"docs/notebooks/example.ipynb"
141+
"docs/notebooks/example.ipynb",
139142
]

0 commit comments

Comments
 (0)