Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the vertical scrollbar doesn't move if you manually go to a slide - is this intentional ? #36

Open
clearly-outsane opened this issue Jul 23, 2020 · 11 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@clearly-outsane
Copy link

As you can see I'm on the first slide yet the scroll bar is at the very bottom
image

Expected Behavior

Actual Behavior

Navigator and OS versions

@thierryc thierryc self-assigned this Jul 23, 2020
@thierryc thierryc added bug Something isn't working good first issue Good for newcomers labels Jul 23, 2020
@thierryc
Copy link
Owner

thierryc commented Jul 23, 2020

Thank you for reporting.

I keep you posted.

Do you have a link to share?

@clearly-outsane
Copy link
Author

clearly-outsane commented Jul 23, 2020

I merely saw the demo on your github. I don't mind helping you fix this by contributing- I am familiar with react !

Edit: One simple solution would be to just disable the scroll bar and make scrollDown event trigger going to the next slide etc.

@thierryc
Copy link
Owner

no the scroll bar is for touch device.

@thierryc
Copy link
Owner

thierryc commented Jul 23, 2020

scrollDown event trigger work well on desktop.
But if you have a better option for touch device, iPad, iPhone, Android, and Surface, I will be happy to test it.

@thierryc
Copy link
Owner

@thierryc thierryc added question Further information is requested and removed bug Something isn't working labels Jul 23, 2020
@clearly-outsane
Copy link
Author

Hmm I will see - I thought these methods will work on desktop and mobile as long as a supported browser is used.

Ah yes even in that link you shared - you can see the scrollbar issue

@thierryc
Copy link
Owner

That the point. I don't have the issue on my side. The scrollbar is on the top.
What is your browser version and OS ?

@thierryc thierryc added the help wanted Extra attention is needed label Jul 23, 2020
@thierryc
Copy link
Owner

Need more info to reproduce.

@clearly-outsane
Copy link
Author

Oh interesting.. I'm using Google Chrome on Windows 10 - let me know if you need more info

@thierryc
Copy link
Owner

Thank you... I will do the test.

@myrealstory
Copy link

myrealstory commented Jul 21, 2022

Hi good day. I had found this problem too however I tried few browser to run my project.
i found the problem on <div name=Driver style={ {height: 6400px} }>, can i modified that or master you have other solution? Thank you very much. (I quite new in react, so i cant simply fix the bug Q-Q thank you very much seriously. )

Best regard,
Gordon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants