Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the list of bookmarks associated to a given source #17

Open
tibonihoo opened this issue May 3, 2015 · 7 comments
Open

Show the list of bookmarks associated to a given source #17

tibonihoo opened this issue May 3, 2015 · 7 comments

Comments

@tibonihoo
Copy link
Owner

No description provided.

@rishabht1
Copy link

Sorry, but i don't clearly understand the complete context of this enhancement. Can you please elaborate on the issue?
Thanks!

@tibonihoo
Copy link
Owner Author

Indeed this wasn't very precise :) The main idea here it to build a new resource (ie a new page) associated to a given "source" (ie one of the items listed in the "your sources" page) and giving access to the list of associated "references". Note that "reference" and "sources" are models precisely defined in wateronmars' code.

That's a good introduction to building a rest-ish feature considering that everything in wateronmars' bakend is ready for that (including way to display list of references). So there's a bit of django-specific python code to write and a bit of html.

@Trey50Daniel
Copy link

I am very experienced with Python and I have experience with HTML, but I would just need to learn how to effectively use django. That shouldn't be hard, but would you be open to my contribution even if it may take a few weeks?

@tibonihoo
Copy link
Owner Author

Sure ! And it doesn't matter if it takes weeks, I'm also quite "slow" on this project.

@Trey50Daniel
Copy link

Okay, great! I'll get right on it! I'm just excited to be able to contribute to open source software!

@Trey50Daniel
Copy link

How do you want to present the bookmarks for a given source? And where are you pulling the bookmarks from, like what file?

@tibonihoo
Copy link
Owner Author

Wateronmars uses q db to store all data. So bookmarks can be accessed via a model (I'm using the standard Django way of accessing data, so you ay want to read Django's doc about that if you're not familiar with it). The model for bookmarks is called Reference https://github.com/tibonihoo/wateronmars/blob/master/wom_pebbles/models.py

Also for the presentation: it would be best imo to be close to the one already set up to display all bookmarks of a user' see https://github.com/tibonihoo/wateronmars/blob/master/wom_user/views.py#L528: the function get_user_collection.

This 'feature' is really about creating a variant of this view where boorkmarks are filtered against a specific source (see the sources field of the Reference class).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants