Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature subpacket type 9 - key expiration time - not parsed #20

Open
JackDca opened this issue Aug 11, 2018 · 1 comment
Open

Signature subpacket type 9 - key expiration time - not parsed #20

JackDca opened this issue Aug 11, 2018 · 1 comment

Comments

@JackDca
Copy link

JackDca commented Aug 11, 2018

A subkey signature packet can have two expiration times:

  • expiry of the signature (subpacket type 3), and
  • expiry of the key that is signed (subpacket type 9).

It appears that only the type 3 subpacket is parsed and used to calculate the attributes raw_expiration_time and expiration_time and subpacket type 9 is not parsed.

The key expiration time is also important. It would be good to have raw_key_expiration_time and key_expiration_time attributes. But ...

There would be a complication in calculating these in that subpacket 9 encodes the expiry as "number of seconds after key creation time" instead of an actual date, and the key creation time is not stored in the signature packet. To avoid problems (e.g. key creation time can't be found in the subkey packet) it would probably be best to instead expose the subpacket 9 value in an attribute called key_lifetime_s and leave any further calculations to the user.

Would the developers welcome a PR to implement that?

@cfcs
Copy link

cfcs commented Oct 14, 2018

Mate I don't think this repo is maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants