From fe7ae9802326ac7e5abb27978508993e7d7d01b1 Mon Sep 17 00:00:00 2001
From: Mojmir Fendek <mfendek@silverstripe.com>
Date: Mon, 10 Feb 2025 09:40:48 +1300
Subject: [PATCH] PR feedback.

---
 .../Extension/FluentSiteTreeExtensionTest.php | 68 +++++++++----------
 1 file changed, 34 insertions(+), 34 deletions(-)

diff --git a/tests/php/Extension/FluentSiteTreeExtensionTest.php b/tests/php/Extension/FluentSiteTreeExtensionTest.php
index 548d592d..5aff541c 100644
--- a/tests/php/Extension/FluentSiteTreeExtensionTest.php
+++ b/tests/php/Extension/FluentSiteTreeExtensionTest.php
@@ -338,7 +338,7 @@ function (FluentState $newState) use ($localeCode, $fixture, $expected) {
      * @param bool $frontendContext
      * @param bool $expected
      * @return void
-     * @dataProvider localeInheritanceModeCasesProvider
+     * @dataProvider provideLocaleInheritanceMode
      */
     public function testLocaleInheritanceMode(
         string $cmsInheritanceMode,
@@ -368,56 +368,56 @@ public function testLocaleInheritanceMode(
         });
     }
 
-    public function localeInheritanceModeCasesProvider(): array
+    public function provideLocaleInheritanceMode(): array
     {
         return [
             'cms with any mode, frontend with any mode, frontend context' => [
-                FluentExtension::INHERITANCE_MODE_ANY,
-                FluentExtension::INHERITANCE_MODE_ANY,
-                true,
-                true,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendContext' => true,
+                'expected' => true,
             ],
             'cms with exact mode, frontend with any mode, frontend context' => [
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                FluentExtension::INHERITANCE_MODE_ANY,
-                true,
-                true,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendContext' => true,
+                'expected' => true,
             ],
             'cms with exact mode, frontend with exact mode, frontend context' => [
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                true,
-                false,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendContext' => true,
+                'expected' => false,
             ],
             'cms with any mode, frontend with exact mode, frontend context' => [
-                FluentExtension::INHERITANCE_MODE_ANY,
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                true,
-                false,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendContext' => true,
+                'expected' => false,
             ],
             'cms with any mode, frontend with any mode, cms context' => [
-                FluentExtension::INHERITANCE_MODE_ANY,
-                FluentExtension::INHERITANCE_MODE_ANY,
-                false,
-                true,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendContext' => false,
+                'expected' => true,
             ],
             'cms with any mode, frontend with exact mode, cms context' => [
-                FluentExtension::INHERITANCE_MODE_ANY,
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                false,
-                true,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendContext' => false,
+                'expected' => true,
             ],
             'cms with exact mode, frontend with exact mode, cms context' => [
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                false,
-                false,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendContext' => false,
+                'expected' => false,
             ],
             'cms with exact mode, frontend with any mode, cms context' => [
-                FluentExtension::INHERITANCE_MODE_EXACT,
-                FluentExtension::INHERITANCE_MODE_ANY,
-                false,
-                false,
+                'cmsInheritanceMode' => FluentExtension::INHERITANCE_MODE_EXACT,
+                'frontendInheritanceMode' => FluentExtension::INHERITANCE_MODE_ANY,
+                'frontendContext' => false,
+                'expected' => false,
             ],
         ];
     }