From 7f8e98fe2a02afc75badcfeef54dfc901f690fe5 Mon Sep 17 00:00:00 2001 From: Fonti Kar Date: Mon, 13 Jan 2025 11:22:59 +1100 Subject: [PATCH] Minor fix in prepartion for CRAN resubmission (#251) * Added rhub checks as part of CI workflow * Bumped version number * Safe guarding versions that come in from github API #248 * Added error message when bad versions #249 * Removing Shiny URL from README as it is currently down with Posit R package issue --- README.Rmd | 6 +----- README.md | 10 ++-------- cran-comments.md | 4 +--- 3 files changed, 4 insertions(+), 16 deletions(-) diff --git a/README.Rmd b/README.Rmd index d6fcd2a..eba91d2 100644 --- a/README.Rmd +++ b/README.Rmd @@ -95,13 +95,9 @@ get_apc_genus_family_lookup(c("Eucalyptus", resources = tax_resources) ``` -## Shiny application ✨ - -We also developed a shiny application for non-R users to update and align their taxonomic names. You can find the application here: https://unsw.shinyapps.io/APCalign-app - ## Cheatsheet - + ## Learn more 📚 diff --git a/README.md b/README.md index 7722f59..10a2dae 100644 --- a/README.md +++ b/README.md @@ -125,15 +125,9 @@ get_apc_genus_family_lookup(c("Eucalyptus", #> 6 Triodia Poaceae ``` -## Shiny application ✨ - -We also developed a shiny application for non-R users to update and -align their taxonomic names. You can find the application here: - - ## Cheatsheet - + ## Learn more 📚 @@ -143,7 +137,7 @@ vignette to learn about how to use `APCalign`. You can also learn more about our [taxa matching algorithm](https://traitecoevo.github.io/APCalign/articles/updating-taxon-names.html). -## Show us support 💚 +## Show us support 💛 Please consider citing our work, we are really proud of it! diff --git a/cran-comments.md b/cran-comments.md index 59a78f4..34bc275 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -4,8 +4,6 @@ * This is a resubmission -* More gracefully handling edge cases involving parts of the internet being down -* Better handling an error in the vignette specific to certain MacOS versions +* Improved handling for release tag versions from Github API * Adding one user function for genus->family lookup -