diff --git a/pkg/handlers/adminapi/office_users.go b/pkg/handlers/adminapi/office_users.go index 06ffe2c7150..88fe01d4e46 100644 --- a/pkg/handlers/adminapi/office_users.go +++ b/pkg/handlers/adminapi/office_users.go @@ -120,7 +120,7 @@ var officeUserFilterConverters = map[string]func(string) func(*pop.Query){ "search": func(content string) func(*pop.Query) { return func(query *pop.Query) { firstSearch, lastSearch, emailSearch := fmt.Sprintf("%%%s%%", content), fmt.Sprintf("%%%s%%", content), fmt.Sprintf("%%%s%%", content) - query.Where("office_users.status = 'APPROVED' AND (office_users.first_name ILIKE ? OR office_users.last_name ILIKE ? OR office_users.email ILIKE ?", firstSearch, lastSearch, emailSearch) + query.Where("(office_users.first_name ILIKE ? OR office_users.last_name ILIKE ? OR office_users.email ILIKE ?) AND office_users.status = 'APPROVED'", firstSearch, lastSearch, emailSearch) } }, "email": func(content string) func(*pop.Query) { diff --git a/pkg/handlers/adminapi/office_users_test.go b/pkg/handlers/adminapi/office_users_test.go index 38b1f226c6a..6f2fe2599aa 100644 --- a/pkg/handlers/adminapi/office_users_test.go +++ b/pkg/handlers/adminapi/office_users_test.go @@ -148,6 +148,7 @@ func (suite *HandlerSuite) TestIndexOfficeUsersHandler() { LastName: "Jolie", Email: "laraCroft@mail.mil", Status: &status, + Telephone: "555-555-5555", }, }, }, []roles.RoleType{roles.RoleTypeTOO}) @@ -158,6 +159,7 @@ func (suite *HandlerSuite) TestIndexOfficeUsersHandler() { LastName: "Bob", Email: "bigBob@mail.mil", Status: &status, + Telephone: "555-555-5555", }, }, }, []roles.RoleType{roles.RoleTypeTIO}) @@ -168,6 +170,7 @@ func (suite *HandlerSuite) TestIndexOfficeUsersHandler() { LastName: "Cage", Email: "conAirKilluh@mail.mil", Status: &status, + Telephone: "555-555-5555", }, }, }, []roles.RoleType{roles.RoleTypeServicesCounselor}) @@ -243,8 +246,7 @@ func (suite *HandlerSuite) TestIndexOfficeUsersHandler() { okResponse = response.(*officeuserop.IndexOfficeUsersOK) suite.Len(okResponse.Payload, 1) - respPhone := *okResponse.Payload[0].Email - suite.Equal(phoneSearch, respPhone[0:len(phoneSearch)]) + respPhone := *okResponse.Payload[0].Telephone suite.Equal(phoneSearch, respPhone[0:len(phoneSearch)]) // firstName search