Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pattern_linewidth aesthetic? #83

Open
trevorld opened this issue Jun 17, 2022 · 2 comments
Open

New pattern_linewidth aesthetic? #83

trevorld opened this issue Jun 17, 2022 · 2 comments
Labels

Comments

@trevorld
Copy link
Owner

  • {ggplot2} is renaming the size aesthetic to linewidth when referring to line widths
  • Should {ggpattern} rename the pattern_size aesthetic to pattern_linewidth when referring to pattern line widths to match the above change?
  • Obviously keep support for pattern_size for backwards compatibility...
@trevorld
Copy link
Owner Author

Perhaps easier if we first support new linewidth parameter in {gridpattern}: trevorld/gridpattern#57

@trevorld trevorld self-assigned this Jun 17, 2022
@trevorld
Copy link
Owner Author

  • Development version of {gridpattern} can now handle either using pattern_linewidth or pattern_size (and makes both available to custom patterns).
  • Looking at what {ggplot2} did it seems keeping backwards compatibility for pattern_size would be a "non-trivial" enterprise and currently there aren't any known patterns that need both a pattern_size and pattern_linewidth aesthetic... Leaning towards not adding a new pattern_linewidth aesthetic for now but would be open to backwards-compatible pull requests that implement this...

@trevorld trevorld removed their assignment Jun 20, 2022
@trevorld trevorld changed the title New 'pattern_linewidth' aesthetic? New pattern_linewidth aesthetic? Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant