Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile manage device - firmware update #14614

Closed
Nodonisko opened this issue Sep 30, 2024 · 4 comments · Fixed by #15184
Closed

Mobile manage device - firmware update #14614

Nodonisko opened this issue Sep 30, 2024 · 4 comments · Fixed by #15184
Assignees
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker

Comments

@Nodonisko
Copy link
Contributor

Nodonisko commented Sep 30, 2024

Figma

Update FW

  • User connects device with supported but older version of FW
  • When user connects device with FW app supported but there is newer version of FW available on dashboard message or in device settings
  • User can Close the message on Dashboard but when he does not update, the message appears again when he reconnect the device

User connects device with unsupported FW

  • When user connects device with unsupported FW, he can't continue to app is prompted to update FW in order to use the app
  • If user has View-only enabled and connects device with no longer supported FW, he is prompted to update the FW on dashboard or he can update it in device settings. User can't close the message on dashboard.

QA

What to test

  1. FW upgrade for all our devices - happy path
  2. FW upgrade failed
    • update rejected on device button request
    • cable disconnected during all different steps of FW upgrade
    • shitty USB cable (if possible)
    • when nothing happens for more than minute it should show button What if it gets stuck? (pressing buttons does nothing for now) and it should dissapear when something happens (progress or user accepts button request on device)
    • Retry button should work in all of these error cases
  3. Test devices with PIN and also without PIN set
  4. Test that remembered devices stays remembered and not remember stays not
  5. Test that discovery doesn't run again for not remembered devices
  6. BTC only FW should work too and stay BTC only and same for Universal FW
  7. FW translations should work too
  8. When system ask for permission after update, try to wait for few minutes before accepting it. It broke it for me once but I was not able to reproduce it then.
  9. Everything should be nicely animated and smooth - I put lot of work into this so don't hesitate to be nit-picky if something doesn't feel right
  10. It's not possible to start FW update during discovery
  11. After installation end user is redirected to origin screen (Home in case of update banner or to device settings)
  12. Changelog modal works correctly
  13. You should have seed ready bottom sheet is displayed before update flow begins
  14. It's not possible to start update flow for unconnected watch-only devices
  15. Remote feature flag works correctly for disabling FW update (not sure how to test it on develop)
  16. It's possible to install FW when I have different device remembered (for example I have TS3 remembered and I am going to install FW on TS3 that is not remembered)
@Nodonisko Nodonisko added the mobile Suite Lite issues and PRs label Sep 30, 2024
@Nodonisko Nodonisko added this to the Mobile - Manage device #1 milestone Sep 30, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Sep 30, 2024
@Nodonisko Nodonisko reopened this Dec 3, 2024
@Nodonisko Nodonisko moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Dec 9, 2024
@evgenysl
Copy link

evgenysl commented Dec 10, 2024

✅ T1 with 1.6.1, 1.9.0
Correctly notifies to update firmware with desktop Trezor Suite.
Device is not usable.

Screenshot_20241210_120734_Trezor Suite Lite Develop

✅ T1 with 1.12.1
There is no message on dashboard or during connect, but "Update" 1.12.1 -> 1.12.1 is available from Device settings (Expected).
Device is usable.

@evgenysl
Copy link

evgenysl commented Dec 10, 2024

✅ TT with 2.5.3
Correctly notifies to update firmware with desktop Trezor Suite.
Device is not usable.

✅ TT with 2.6.3, 2.6.4, 2.7.0, 2.7.2
Update is not offered Home or any dashboard message (Expected for now).
Update to 2.8.1 is available from Device settings.
Device is usable without firmware update.

Multiple updates are successful.

@evgenysl
Copy link

evgenysl commented Dec 10, 2024

Don't know if it's my slow tablet's issue, but this loading circle takes cca. 10 seconds before it changes to blue Update button.
Edit: it's because of coin discovery.

Screenshot_20241210_235740_Trezor Suite Lite Develop

@STew790
Copy link
Contributor

STew790 commented Jan 23, 2025

QA OK
Update T3B1 and T2B1 to latest OK ✅
Update T3T1 to latest OK ✅
Reinstall of FW works on all devices as well ✅
Installation of BTC only fw works too ✅

  • tested both with PIN and without PIN

  • what if it gets stuck modal LGTM and appears after a while when nothing is happening

  • I tried to disrupt the FW update multiple ways and multiple times and seems to work nicely, when I connect the device back, I can easily continue with the update (works very nice imo 🎉 ) or I can just "quit" it and continue to dashboard or whatever I want

  • view only devices stayed view only and vice versa

  • correctly differentiates Universal FW and BTC only fw

  • BTC only fws update works as well

  • animations feels nice and smooth, haven't seen any stuttering or anything 🙏

  • I wasn't able to replicate 8.

  • update not possible while discovery is going (as @evgenysl mentioned as well)

  • bottom sheet about seed displayed every time

  • view only wallets are not possible to update

  • tested also: TS3 and TT in view only (not connected) and update of TS5 (that was not in view only) and update went well

  • works well also with biometrics (locked my phone after the fw update>unlocked>was asked for biometrics>FW finished fine)

  • could not yet test the remote ff disable

  • changelog is not present

Info
25.1.2 b6893f7

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Jan 23, 2025
@STew790 STew790 closed this as completed by moving to ✅ Approved in Suite Mobile Jan 23, 2025
@STew790 STew790 added QA OK Issue passed QA without any blocker and removed Testing-Evgeny labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

3 participants