Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sol Stake: account staking banner #16359

Closed
tomasklim opened this issue Jan 14, 2025 · 2 comments · Fixed by #16441 or #16563
Closed

Sol Stake: account staking banner #16359

tomasklim opened this issue Jan 14, 2025 · 2 comments · Fixed by #16441 or #16563
Labels
QA OK Issue passed QA without any blocker

Comments

@tomasklim
Copy link
Member

tomasklim commented Jan 14, 2025 •
edited
Loading

Image
Image
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Jan 14, 2025
@tomasklim tomasklim moved this to Todo in 🥩 Staking Jan 14, 2025
@dev-pvl dev-pvl mentioned this issue Jan 17, 2025
Merged
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jan 22, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in 🥩 Staking Jan 22, 2025
@bosomt
Copy link
Contributor

bosomt commented Jan 23, 2025

QA OK

Image
  • learn more takes you to stake section
  • x closes banner

QA NOK

  • staking banner is available even when staking is not available /debug mode disabled/
  • it will take you to staking even staking tab is disabled @tomasklim is that issue or not ?
Image

@tomasklim tomasklim mentioned this issue Jan 23, 2025
Merged
@STew790
Copy link
Contributor

STew790 commented Jan 23, 2025

QA OK
Fixed by #16563 I dont see the staking banner when I disable debug mode.

Info:

  • Suite version: web 25.2.0 (e441a1a)
  • Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: Trezor T2T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: WebUsbTransport

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jan 23, 2025
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA OK Issue passed QA without any blocker
Projects
Suite Desktop
Status: ✅ Approved
🥩 Staking
Status: Done
Milestone
No milestone
3 participants
@bosomt @tomasklim @STew790