feat(suite): added blockbook link to approval tx #16434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izmy
reviewed
Jan 17, 2025
...mmon/CoinmarketSelectedOffer/CoinmarketOfferExchange/CoinmarketOfferExchangeSendApproval.tsx
Outdated
Show resolved
Hide resolved
adderpositive
requested changes
Jan 17, 2025
...mmon/CoinmarketSelectedOffer/CoinmarketOfferExchange/CoinmarketOfferExchangeSendApproval.tsx
Outdated
Show resolved
Hide resolved
tomasklim
reviewed
Jan 20, 2025
...mmon/CoinmarketSelectedOffer/CoinmarketOfferExchange/CoinmarketOfferExchangeSendApproval.tsx
Outdated
Show resolved
Hide resolved
tomasklim
requested changes
Jan 20, 2025
...mmon/CoinmarketSelectedOffer/CoinmarketOfferExchange/CoinmarketOfferExchangeSendApproval.tsx
Outdated
Show resolved
Hide resolved
|
I've created follow-up issue #16466 |
tomasklim
approved these changes
Jan 23, 2025
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12925895412 |
trezor-ci
force-pushed
the
approval-tx-blockbook-link
branch
from
7e8c93b to
071d6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After approving a token to swap, while the blockchain is confirming the approval transaction, allow the user to copy the approval transaction ID as well as redirect to blockbook transaction detail page.
Related Issue
Resolve #14840
Screenshots:
On moving the mouse over the transaction ID, options to copy the transaction ID or go to the blockbook transaction detail page are displayed.
Upon clicking the redirect button, the user is redirected to the blockbook transaction detail page.