fix(suite-native): empty homescreen paddings #16529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
yanascz
reviewed
Jan 22, 2025
suite-native/module-home/src/screens/HomeScreen/components/EmptyConnectedDeviceState.tsx
Outdated
Show resolved
Hide resolved
yanascz
reviewed
Jan 22, 2025
suite-native/module-home/src/screens/HomeScreen/components/EmptyHomeRenderer.tsx
Outdated
Show resolved
Hide resolved
yanascz
reviewed
Jan 22, 2025
suite-native/module-home/src/screens/HomeScreen/components/EmptyHomeRenderer.tsx
Outdated
Show resolved
Hide resolved
yanascz
reviewed
Jan 23, 2025
Comment on lines
+17
to
+19
| paddingTop: utils.spacings.sp32, | ||
| paddingBottom: utils.spacings.sp16, | ||
| paddingHorizontal: utils.spacings.sp16, |
There was a problem hiding this comment.
I try to maintain this order – top, horizontal, bottom. Inspired by CSS:
/* top | left and right | bottom */
padding: 1em 2em 2em;
Feel free to ignore. 🙂
PeKne
force-pushed
the
fix/native/empty-homescreen-paddings
branch
from
6271670 to
2f0139b
Compare
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12926079159 |
trezor-ci
force-pushed
the
fix/native/empty-homescreen-paddings
branch
from
2f0139b to
4f0a084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes empty dashboard paddings according to this design.