Minor Solana fixes from Sentry #16554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
tomasklim
reviewed
Jan 23, 2025
packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketExchangeForm.ts
Show resolved
Hide resolved
adderpositive
requested changes
Jan 23, 2025
There was a problem hiding this comment.
According to these fixes, I believe useSolanaSubscribeBlocks(account); should be added to the useCoinmarketSellForm. We work with account as well. @martykan could you verify it, please?
packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketExchangeForm.ts
Outdated
Show resolved
Hide resolved
packages/suite/src/hooks/wallet/coinmarket/form/useCoinmarketExchangeForm.ts
Show resolved
Hide resolved
|
Yes, good point, just added it |
adderpositive
approved these changes
Jan 23, 2025
martykan
force-pushed
the
fix/solana-sentry
branch
from
a4c82c4 to
9902f9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiple fixes for Solana issues from Sentry.
Subscribe to Solana blocks in coinmarket form (resolves Could not simulate transaction: BlockhashNotFound #16534)
Solana account.misc may be undefined - when still loading or on backend issues (resolves TypeError: Cannot read properties of undefined (reading 'solStakingAccounts') #16538, resolves TypeError: Cannot destructure property 'solStakingAccounts' of 'e.misc' as it is undefined. #16537)
Don't log error when solana RPC channel closed (resolves SolanaError: Solana error #8190003; Decode this error by running
npx @solana/errors decode -- 8190003#16539)