Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile releases.json into TS #17214

Open
Lemonexe opened this issue Feb 25, 2025 · 0 comments
Open

Compile releases.json into TS #17214

Lemonexe opened this issue Feb 25, 2025 · 0 comments
Assignees

Comments

@Lemonexe
Copy link
Contributor

Lemonexe commented Feb 25, 2025

releases.json for all device models are available from two sources:

  1. locally as json files (Suite Desktop & Suite Lite)
  2. data.trezor.io (Suite Web, also fallback for both Desktop & Lite if local files are suspected to be outdated)

Local json files are not part of the JS bundle - they are external files, loaded by a runtime require, which may not always load successfully - I suspect that this could be the true root cause for #16725, which was resolved only superficially.

👉 Rewrite the files into TS, so that they are part of JS bundle. Those are to be maintained manually (currently, the jsons are also manually updated).
We have a CI script that checks consistency with data repo ➡ update to check the TS files.

💡 instead of yarn build:libs, this routine could be triggered as a postinstall script for better DX - so that devs won't have to run build:libs, which is time consuming

@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Feb 25, 2025
@Lemonexe Lemonexe self-assigned this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎯 To do
Development

No branches or pull requests

1 participant