fix(suite): redirect to index from /start, /onboarding if not initialRun #17286
Conversation
WalkthroughThe changes modify application navigation by introducing a conditional redirection mechanism based on the application's initial run state. A new component, ✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/suite/src/components/suite/Preloader/Preloader.tsx (1)
124-126: Consider addressing the TODO about fullscreen app logic in a future PR.While not directly related to the current changes, the TODO comment indicates there might be room for improvement in the fullscreen app logic architecture. This could be worth exploring in a separate refactoring PR.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/suite/src/components/suite/Preloader/Preloader.tsx(3 hunks)packages/suite/src/support/suite/Redirect.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: e2e-test-suite-web (@group=other)
- GitHub Check: e2e-test-suite-web (@group=metadata2)
- GitHub Check: e2e-test-suite-web (@group=metadata1)
- GitHub Check: run-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=passphrase, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: run-desktop-tests (@group=suite, trezor-user-env-unix)
🔇 Additional comments (5)
packages/suite/src/support/suite/Redirect.tsx (1)
1-26: Well-designed and documented Redirect component.This new component effectively handles redirection while maintaining Redux state synchronization with React Router. The use of
useLayoutEffectinstead ofuseEffectis a thoughtful choice to prevent flickering during redirection.packages/suite/src/components/suite/Preloader/Preloader.tsx (4)
29-29: Appropriate import of the new Redirect component.The import statement correctly references the new custom Redirect component that maintains Redux state synchronization.
44-45: Good pattern for Dashboard redirection.Creating a dedicated component for dashboard redirection improves maintainability and makes the codebase more expressive by clearly communicating the redirect destination.
46-58: Effective conditional redirection implementation.The updated function signature with the added
isInitialRunparameter allows for clean conditional rendering. The implementation successfully addresses the PR objective by redirecting users away from start/onboarding screens when not in initial run state.
127-127: Correctly passes initialRun state to getFullscreenApp.This change properly integrates the existing Redux state with the modified function signature, ensuring the redirect logic works as intended.
Lemonexe
deleted the
fix/loading-onboarding-routes-when-not-initialRun
branch
Description
Redirectcomponent, that replaces the same-namedRedirectfromreact-router-dom/start, /onboardingto redirect to Dashboard / connecting screen if onboarding is finishedRelated Issue
Resolve #17285
Screenshots:
redirects.webm