macOS/Windows version is incorrectly reported which breaks analytics and message system

[tomasklim]

Describe the bug

• our current v1 version of ua-parser-js detects computer data from user agent which does not reflect macOS version correctly

• update this lib to v2 https://docs.uaparser.dev/intro/whats-new.html

https://www.notion.so/satoshilabs/e19845789ccb47a0baf36d7f8463f196?v=2183c8228ebb4df38f358d1b2744e1b8&p=f1129e10da8d418da11186761754ad36&pm=s

Info:

• Suite Version: 23.6.0

How to reproduce

1. Check analytics

Expected behavior
macOS version is reported correctly

Screenshots

[tomasklim]

Add note that it was fixed here https://www.notion.so/satoshilabs/Changelog-Suite-1551ab666b1943f080ff56ffc6896d12

[sime]

Inspired by electron/electron#3012 (comment) for desktop suite, we can invoke os.version() and deduce the macOS version based on the kernel version.

> os.version()
'Darwin Kernel Version 22.6.0: Mon Feb 19 19:43:41 PST 2024; root:xnu-8796.141.3.704.6~1/RELEASE_ARM64_T8103'

Where xnu-8796 is the darwin version for macOS 13.7 (Ventura)

[tomasklim]

@komret https://docs.uaparser.dev/guides/how-to-detect-macos-10157-using-javascript.html please check

[Lemonexe]

@tomasklim I believe this is solved in #15789. I did not know about this issue..
The article you linked says it's impossible to detect from userAgent alone, that's why I've added another field, obtained from node api. And it is only available on desktop, not on web 😞

Also, it cannot be used in message system until someone adds conditions for desktopOsVersion to messageSystemUtils

[tomasklim]

@tomasklim I believe this is solved in #15789. I did not know about this issue..

it is not. I believe nobody knows what does this mean

Also, it cannot be used in message system until someone adds conditions for desktopOsVersion to messageSystemUtils

Why desktopOsVersion? It can be unified

    uap.getOS()
        .withClientHints()
        .then(os => {
            console.log('Is desktop', isDesktop(), os);
        });

desktop:

web:

[tomasklim]

I believe except architecture, this logic can be removed #15770

[tomasklim]

Also resolve this please #6877