Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource group #36

Merged
merged 12 commits into from
Feb 3, 2025
Merged

Resource group #36

merged 12 commits into from
Feb 3, 2025

Conversation

u110
Copy link
Collaborator

@u110 u110 commented Jan 24, 2025

Summary

added a new resource resource_group.

@u110 u110 marked this pull request as ready for review January 24, 2025 05:36
@u110 u110 requested a review from gtnao as a code owner January 24, 2025 05:36
@katamotokosuke
Copy link
Collaborator

The description was optional, so I commented out the description when updating and applied terraform and got an error.

╷
│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to trocco_resource_group.test_resource_group, provider "provider[\"local/trocco-io/trocco\"]" produced an unexpected new value: .description: was
│ null, but now cty.StringVal("test_resource_group description").
│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.

@katamotokosuke
Copy link
Collaborator

I got an error when I sent it with empty name.


Terraform will perform the following actions:

  # trocco_resource_group.test_resource_group will be updated in-place
  ~ resource "trocco_resource_group" "test_resource_group" {
        id          = 13
      ~ name        = "test_resource_group" -> ""
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

trocco_resource_group.test_resource_group: Modifying... [name=test_resource_group]
╷
│ Error: Updating team
│ 
│   with trocco_resource_group.test_resource_group,
│   on main.tf line 625, in resource "trocco_resource_group" "test_resource_group":
│  625: resource "trocco_resource_group" "test_resource_group" {
│ 
│ Unable to update team, got error: 422 Unprocessable Content
╵

@u110
Copy link
Collaborator Author

u110 commented Jan 29, 2025

I got an error when I sent it with empty name.

Thank you for confirmation of the behavior!
Added validation for lower character limit.

@u110 u110 requested a review from katamotokosuke January 29, 2025 02:32
@u110 u110 merged commit 35ac22e into main Feb 3, 2025
6 checks passed
@u110 u110 deleted the resource-group branch February 3, 2025 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants