add connection_type: S3

[u110]

Summary

It adds a new connector type s3.

Note

• TROCCO's Web API for S3 is not yet publicly available, so do not merge right now.

Changes

• Add connector_type: s3

[okeyaki]

IMO: It seems the secret access key is a dummy. However, it would be troublesome to be detected tools like git-secrets, so the following description might work better:

secret_access_key = "YOUR_SECRET_ACCESS_KEY"

[u110]

it's seems to be better!

• fixed 3072248

[okeyaki]

ASK: Cannot AWSIAMUser: plan.NewAWSIAMUser() be replaced with AWSIAMUser: plan.AWSIAMUser?

[u110]

I ran it with the suggested modifications and there seemed to be no problem.
so, there looked to be no need to COPY it.

[u110]

• 138650c

[u110]

AssumeRole is included in the API results, so I modified it to refer to it.

• 425b1f3

[okeyaki]

IMO: It seems to be a bit better to implement AWSIAMUser.Copy() instead of NewAWSIAMUser.

[u110]

• fixed, thx! d4037ec

[katamotokosuke]

resource "trocco_connection" "s3" {  
  name        = "S3 Example"  
  connection_type = "s3"  
  description = "This is a AWS S3 connection example"  
  
  aws_auth_type = "iam_user"  
  aws_iam_user = {  
    access_key_id     = "YOUR_ACCESS_KEY_ID"  
    secret_access_key = "YOUR_SECRET_ACCESS_KEY"  
  }  
  aws_assume_role = {  
    account_id = "s"  
    role_name = "role_name"  
  }  
}

If you specify aws_iam_user and aws_assume_role at the same time, there will always be a difference.

kosuke.katamoto@pN-mac-0001 terraform-test-for-trocco % terraform apply
trocco_connection.s3: Refreshing state... [name=S3 Example]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # trocco_connection.s3 will be updated in-place
  ~ resource "trocco_connection" "s3" {
      + aws_assume_role = {
          + account_id = "s"
          + role_name  = "role_name"
        }
        id              = 4
        name            = "S3 Example"
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

trocco_connection.s3: Modifying... [name=S3 Example]
trocco_connection.s3: Modifications complete after 1s [name=S3 Example]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.
kosuke.katamoto@pN-mac-0001 terraform-test-for-trocco % terraform apply
trocco_connection.s3: Refreshing state... [name=S3 Example]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # trocco_connection.s3 will be updated in-place
  ~ resource "trocco_connection" "s3" {
      + aws_assume_role = {
          + account_id = "s"
          + role_name  = "role_name"
        }
        id              = 4
        name            = "S3 Example"
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

trocco_connection.s3: Modifying... [name=S3 Example]
trocco_connection.s3: Modifications complete after 0s [name=S3 Example]

Apply complete! Resources: 0 added, 1 changed, 0 destroyed.

[u110]

If you specify aws_iam_user and aws_assume_role at the same time, there will always be a difference.

I'll add validation process for not to use together aws_iam_user and aws_assume_role, thx!

• fixed! 2a8b2f8