Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: redundant "last updated" timestamp in forecast and RT snapshots #158

Closed
catkins-miso opened this issue Sep 10, 2024 · 1 comment · Fixed by #159
Closed

BUG: redundant "last updated" timestamp in forecast and RT snapshots #158

catkins-miso opened this issue Sep 10, 2024 · 1 comment · Fixed by #159
Assignees
Labels
Task catch-all for tasks not associated with spec changes

Comments

@catkins-miso
Copy link
Contributor

image
I think this probably is a result of DRYing up the source/snapshot-provenance. Changing this is technically a spec change, but I hope we can treat it as just a clean-up.

Relatedly, the forecast examples have a superfluous "updated-time"
https://github.com/trolie/spec/blame/409e215cd7dddfae2efcd5f344faadfd826c8f53/docs/example-narratives/examples/forecast-limits-detailed.json#L48

This should be removed.

@catkins-miso catkins-miso added the Task catch-all for tasks not associated with spec changes label Sep 10, 2024
@catkins-miso
Copy link
Contributor Author

catkins-miso commented Sep 10, 2024

FWIW, the superfluous property wasn't caught by the linter because we couldn't use additionalProperties: false on the rating schema , as discussed here https://stackoverflow.com/a/23001194

Moving to OpenAPI 3.1.0 would allow us to use unevaluatedProperties: false which has the desired effect.

Another option would be to use <<: *anchor as we've done in other places rather than the built-in allOf method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task catch-all for tasks not associated with spec changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants