Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty guidelines and PS blues are added on save to fontinfo.plist #510

Closed
anthrotype opened this issue Oct 31, 2017 · 4 comments
Closed

Comments

@anthrotype
Copy link
Member

this is a minor thing, I post it here so that I don't forget about it.

I noticed that if when I open a UFO that does not have any global guidelines or does not define any postscript blues in the fontinfo.plist, whenever I save it back with Trufont, empty arrays automatically get added for those values in the fontinfo.plist.

--- a/tests/data/RobotoSubset-Regular.ufo/fontinfo.plist
+++ b/tests/data/RobotoSubset-Regular.ufo/fontinfo.plist
@@ -2,6 +2,27 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
        <dict>
+               <key>guidelines</key>
+               <array>
+               </array>
+               <key>postscriptBlueValues</key>
+               <array>
+               </array>
+               <key>postscriptFamilyBlues</key>
+               <array>
+               </array>
+               <key>postscriptFamilyOtherBlues</key>
+               <array>
+               </array>
+               <key>postscriptOtherBlues</key>
+               <array>
+               </array>
+               <key>postscriptStemSnapH</key>
+               <array>
+               </array>
+               <key>postscriptStemSnapV</key>
+               <array>
+               </array>
                <key>unitsPerEm</key>
                <integer>2048</integer>

I think those elements are optional, so it'd be nice if TruFont didn't add them if they are not already there, and the user didn't use them either.

@moyogo
Copy link
Contributor

moyogo commented Nov 4, 2017

This seems to be a lower level issue. Font().save('test.ufo') will generate a fontinfo.plist with those empty plist items.

@anthrotype
Copy link
Member Author

I see, thanks. Let's move this over to defcon then

@mashabow
Copy link

robotools/defcon#173

@madig
Copy link
Contributor

madig commented Sep 20, 2019

Defcon issue.

@madig madig closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants